[EMB-167] Use link-to for internal links #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binoculars
reviewed
Mar 21, 2018
| }); | ||
|
|
||
| actions = { | ||
| ...this.actions, // from AnalyticsMixin |
Member
There was a problem hiding this comment.
Nice! I didn't realize that this is possible.
aaxelb
force-pushed
the
emb-167--link-to
branch
from
00620ad to
81ba72f
Compare
jamescdavis
previously approved these changes
Mar 21, 2018
Member
jamescdavis
left a comment
jamescdavis
left a comment
There was a problem hiding this comment.
Looks good once conflicts are resolved.
| "bower_components" | ||
| "include": [ | ||
| "app", | ||
| "tests" |
Member
There was a problem hiding this comment.
TY! I was going to do this as a separate PR.
|
|
||
| // TODO: When used in other apps, update to expect these as arguments or from the config | ||
| hostAppName: string = HOME_APP; | ||
| linksComponent: string = 'osf-navbar/home-links'; |
Member
There was a problem hiding this comment.
I like this approach much better than the one "link builder for all the apps" helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use the
{{link-to}}component for all internal links in ember-osf-web. Don't reload the page if we don't have to.Summary of Changes
link-toto acceptariaLabelandonClickarguments, to preserve existing behaviorlink-towhile others are<a>new-osf-navbar=>osf-navbarnew-navbar-auth-dropdown=>osf-navbar/auth-dropdownbuild-secondary-nav-linkshelper replaced withosf-navbar/home-linkscomponenthost-app-namemixinget-display-namehelperSide Effects / Testing Notes
Ticket
https://openscience.atlassian.net/browse/EMB-167
Reviewer Checklist
CHANGELOG.md