Skip to content

Conversation

@fabmiz
Copy link
Member

@fabmiz fabmiz commented Jun 25, 2021

Purpose

When autosave fails on the draft-registration metadata, the notice in the right sidebar is not showing up.

Summary of Changes

  • Update DraftRegistrationManager.lastSaveFailed computed property to update on status of onMetadataInput task.
  • Make notice red (actually have rules in the notice existing local class)

Side Effects

N/A

QA Notes

  • On a draft-registration metadata page, currently, one way to cause an auto-save error is by deleting the autofilled year
    on a license with required fields (for example No License, MIT License); you should see an error toast then in the right sidebar; a notice similar to the one below should show.

Screen Shot 2021-06-25 at 9 58 46 AM

}
}

.SaveFailed {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to have another .SaveFailed class in draft/style.scss that is not used. Might as well remove that class in favor of this one here.

@fabmiz
Copy link
Member Author

fabmiz commented Jun 25, 2021

@adlius fixed.

Copy link
Contributor

@adlius adlius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@fabmiz fabmiz merged commit 3639e76 into CenterForOpenScience:release/21.6.0 Jun 25, 2021
@fabmiz fabmiz added this to the 21.6.0 milestone Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants