[EMB-168] Improve between-requests loading experience in dashboard project viewer #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binoculars
reviewed
Mar 21, 2018
app/dashboard/controller.ts
Outdated
| findNodes: task(function* (this: Dashboard, more?: boolean) { | ||
| findNodes: task(function* (this: Dashboard, more?: boolean, search?: boolean) { | ||
| const indicatorProperty = `loading${more ? 'More' : ''}`; | ||
| if (search) { |
Member
There was a problem hiding this comment.
Wouldn't it make more sense to move this to the filterNodes task? I.e. set it to true before the yield then false after the yield.
| @@ -1,3 +1,7 @@ | |||
| <div class='ball-scale ball-light LoadingIndicator'> | |||
| <div class='ball-{{if pulse "pulse" "scale"}} {{if blue "ball-scale-blue"}} {{if dark "ball-dark" "ball-light"}} LoadingIndicator'> | |||
Contributor
There was a problem hiding this comment.
Drive-by: Per product consultation, remove this, and when no products are found and loading, change the "No projects found" to either be the normal loading pulser or have it say, "Loading…". The pulser is better because a) it should be there already; and b) no extra text.
jamescdavis
reviewed
Mar 21, 2018
app/dashboard/controller.ts
Outdated
| yield timeout(500); | ||
| this.setProperties({ filter }); | ||
| yield this.get('findNodes').perform(); | ||
| yield this.get('findNodes').perform(false, true); |
Member
There was a problem hiding this comment.
What is the second parameter to perform for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve the loading experience between request as users filter/sort their projects on dashboard.
Summary of Changes
Ticket
https://openscience.atlassian.net/browse/EMB-168
Reviewer Checklist
CHANGELOG.md