Skip to content

Update to ember 3 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamescdavis merged 12 commits into from
Mar 26, 2018
Merged

Update to ember 3 #129

jamescdavis merged 12 commits into from
Mar 26, 2018

Conversation

@jamescdavis
Copy link
Member

@jamescdavis jamescdavis commented Mar 26, 2018

Purpose

Update to ember-cli, ember-source, and ember-data 3.

Summary of Changes

Upgrade to ember

Side Effects / Testing Notes

Probably needs full regression.

Ticket

n/a

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@coveralls
Copy link

coveralls commented Mar 26, 2018

Coverage Status

Coverage remained the same at 21.122% when pulling af82659 on jamescdavis:update-to-ember-3 into fcff44f on CenterForOpenScience:develop.

brianjgeiger
brianjgeiger previously approved these changes Mar 26, 2018
View reviewed changes
@jamescdavis
Copy link
Member Author

jamescdavis commented Mar 26, 2018

Passing build: https://travis-ci.org/jamescdavis/ember-osf-web/builds/358492681

binoculars
binoculars previously approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member

@binoculars binoculars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@jamescdavis
Copy link
Member Author

jamescdavis commented Mar 26, 2018

Passing build: https://travis-ci.org/jamescdavis/ember-osf-web/builds/358511894

@jamescdavis jamescdavis merged commit 811a7d9 into CenterForOpenScience:develop Mar 26, 2018
@jamescdavis jamescdavis deleted the update-to-ember-3 branch March 26, 2018 17:31
@jamescdavis jamescdavis added this to the 0.3.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianjgeiger brianjgeiger brianjgeiger left review comments

+1 more reviewer

@binoculars binoculars binoculars left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jamescdavis @coveralls @binoculars @brianjgeiger