Skip to content

Conversation

@jamescdavis
Copy link
Member

Purpose

Remove multiple instances of ember types (which confuses TypeScript).

Summary of Changes

  • upgrade to latest @types/ember
  • merge @types/ember@* and @types/ember@^2.8.16 in yarn.lock
  • also upgrade to latest @types/ember-data while we're here

Side Effects / Testing Notes

Less TS errors

Ticket

n/a

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@jamescdavis jamescdavis merged commit b9e1cdc into CenterForOpenScience:develop Mar 26, 2018
@jamescdavis jamescdavis deleted the remove_duplicate_ember_types branch March 26, 2018 18:01
@coveralls
Copy link

Coverage Status

Coverage remained the same at 21.122% when pulling 8ced6b5 on jamescdavis:remove_duplicate_ember_types into 811a7d9 on CenterForOpenScience:develop.

@jamescdavis jamescdavis added this to the 0.3.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants