[ENG-3035] Update Registration Cards #1308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `settings` route, nest `notifications` + bulk upload widget under `settings` * Add bulk upload component * Add tests * Bump ember-template-lint
…translation file for button.
… translation file for multiple buttons, added schema response to registration for rendering hbs.
…translation file for button.
…evision.index, changed type of button to create, added transitionTo function with createNewSchemaResponse on card view.
…tate is accepted or embargo.
chth0n1x
force-pushed
the
feature/my-registrations-update-button
branch
from
842374c to
87f8058
Compare
- Ticket: [ENG-2969](https://openscience.atlassian.net/browse/ENG-2969) - Feature flag: n/a ## Purpose Fixes for accessibility issues on the registries discover page, including the navbar. ## Summary of Changes 1. Navbar auth-dropdown gets an aria-label 2. Sort dropdown gets a role 3. Search bar gets an aria-label ## QA Notes Just needs to be run through the selenium tests for accessibility again.
- Ticket: [ENG-3169](https://openscience.atlassian.net/browse/ENG-3169) - Feature flag: n/a ## Purpose Fix the link colors on the Sign-Up Page ## Summary of Changes 1. Use $color-link-dark instead of the standard color for links on this form. ## Side Effects No ## QA Notes This change is isolated to the form.
…cience#1249) - Ticket: [ENG-3013](https://openscience.atlassian.net/browse/ENG-3013) - Feature flag: n/a ## Purpose Fix accessibility issues on the institutional landing page. ## Summary of Changes 1. Add a 'main' landmark 2. Add an aria label to the load more button 3. Add translation string for the load more button's aria label ## QA Notes This should just need selenium testing to verify the fixes are all good there.
…nterForOpenScience#1269) Tickets: - [ENG-3160](https://openscience.atlassian.net/browse/ENG-3160) - [ENG-3162](https://openscience.atlassian.net/browse/ENG-3162) ## Purpose Fix a couple of contrast problems from the Project:Analytics tab and the Project:Registrations tab. ## Summary of Changes 1. Make active text brighter on the node navbar 2. Make the text darker on the analytics headers ## Side Effects Anywhere else that might use the node navbar styling will have the brighter text, but that shouldn't be used anywhere else, and will hardly be noticeable if it is. ## QA Notes This should just be regression tested with the a11y tools.
- Ticket: [ENG-3245](https://openscience.atlassian.net/browse/ENG-3245) - Feature flag: n/a ## Purpose Update the help guide link on the project registrations page to one that is not broken. ## Summary of Changes 1. Update the link in both places it's used. ## Side Effects Nope ## QA Notes Make sure the new link goes to a help page for registrations.
futa-ikeda
requested changes
Nov 3, 2021
Contributor
futa-ikeda
left a comment
futa-ikeda
left a comment
There was a problem hiding this comment.
Had some feedback and a couple of questions
Comment on lines
198
to
200
| {{#if this.shouldShowUpdateButton}} | ||
| {{#unless (not-eq this.node.reviewsState 'accepted')}} | ||
| {{#if this.latestSchemaResponse}} |
Contributor
There was a problem hiding this comment.
I think the condition here needs a bit of tweaking. There's a couple scenarios that we should be aware of
- if there is a revision in progress, we should link to it
- if a registration does not have a revision in progress, we will need to create one
The logic in place here addresses the first scenario, but not the second.
Contributor
Author
There was a problem hiding this comment.
Ok, the logic in place is {{else if this.shouldShowLinkToUpdate}} <Button {{on 'click' (perform this.createNewSchemaResponse)}} disabled={{this.createNewSchemaResponse.isRunning}} />
Contributor
Author
There was a problem hiding this comment.
Will this resolve the second condition?
Contributor
There was a problem hiding this comment.
I think the template file looks correct right now the way it is. We may want to tweak some of the logic in the shouldShowUpdateButton computed property, but we can update those in the component.ts file. We will also need to add a new computed property called shouldShowLinkToUpdate in the component.ts file so a link to the existing revision in progress is shown appropriately:
{{#if this.shouldShowUpdateButton}}
<Button
{{on 'click' (perform this.createNewSchemaResponse)}}
disabled={{this.createNewSchemaResponse.isRunning}}
/>
{{else if this.shouldShowLinkToUpdate}}
<OsfLink
data-analytics-name='Update'
data-test-update-button='{{@node.id}}'
@route='registries.edit-revision.index'
@models={{array this.latestSchemaResponse.id}}
>
<Button
local-class='RegistrationCard_update'
>
{{t 'node_card.update_button'}}
</Button>
</OsfLink>
{{/if}}
^ some of the tabbing will need to be cleaned up, but the logic is sound
…ub.com/chth0n1x/ember-osf-web into feature/my-registrations-update-button Pulling updated PR changes for make decision dropdown.
…der is undefined (CenterForOpenScience#1339) - Ticket: n/a - Feature flag: n/a ## Purpose When doing a search from the registries landing page, we would get an error on the discover page that we couldn't load the registration types. This happened because provider was becoming undefined after the await L45 in the diff for this PR was executed. ## Summary of Changes 1. Wait for attrs to load before running task (h/t @aaxelb) ## Side Effects This should be pretty isolated ## QA Notes Original error was when performing a search from the registries landing page, the error above would show on the discover page. This should no longer happen.
…ence#1247) - Ticket: [ENG-3018](https://openscience.atlassian.net/browse/ENG-3018) - Feature flag: n/a ## Purpose Fix the accessibility problems with the usage of Bootstrap Tabs on the draft metadata page. ## Summary of Changes 1. Replace the BsTab with ember-aria-tabs ## Side Effects Should be all localized to that page and control. I had to do a little work to keep from re-styling the list of subjects. ## QA Notes Make sure the tabs still work, and make sure the aria problems are fixed.
Updating logic for if user should be able to create an update with on click mouse event. Co-authored-by: futa-ikeda <51409893+futa-ikeda@users.noreply.github.com>
…ton for update links, and improved logic to include embargo states, if user is admin.
…ub.com/chth0n1x/ember-osf-web into feature/my-registrations-update-button Merging upstream changes from PR review.
…enterForOpenScience#1309) - Tickets: [ENG-3233](https://openscience.atlassian.net/browse/ENG-3233) [ENG-3235](https://openscience.atlassian.net/browse/ENG-3235) - Feature flag: n/a ## Purpose Fix accessibility problems on the Collections discover page. ## Summary of Changes 1. Add aria-label to search input 2. Remove unnecessary aria-label from drop-down icon 3. Make active Facet marker more contrasty 4. Make "No search results" text more contrasty 5. Move aria label from span around the 'remove' button to the 'remove' button itself. ## Side Effects No, these should be isolated. ## QA Notes These changes shouldn't affect functionality, just accessibility.
…ience#1337) - Ticket: [https://openscience.atlassian.net/browse/ENG-3214] - Feature flag: n/a ## Purpose Add an aria label to the search box on the meetings detail page. Apparently last time I got the meeting list page, but not the detail page's search box. ## Summary of Changes 1. Add aria label ## Side Effects No ## QA Notes Just needs a11y testing.
…1340) - Ticket: [ENG-3235](https://openscience.atlassian.net/browse/ENG-3235) - Feature flag: n/a ## Purpose The description text on the collections discover page was not passing accessibility standards of contrast. This fixes that. ## Summary of Changes 1. Un-mute the text ## Side Effects None ## QA Notes Just needs to run through accessibility testing.
…sion page (CenterForOpenScience#1315) - Tickets: [ENG-3237](https://openscience.atlassian.net/browse/ENG-3237) [ENG-3238](https://openscience.atlassian.net/browse/ENG-3238) - Feature flag: n/a ## Purpose Fix the accessibility problems on the Collections submission page ## Summary of Changes 1. Darken header text for each input section 2. Add aria label to search text input 3. Add aria label to search action button 4. Remove hidden label from bibliographic checkboxes 5. Add aria label to bibliographic checkboxes ## Side Effects No, these should be isolated ## QA Notes Functionality shouldn't be affected, only accessibility.
- Ticket: [No ticket] - Feature flag: n/a ## Purpose - Fix the registries overview's subject search widget ## Summary of Changes - Load the registration provider before querying its subjects - Update types accordingly ## Side Effects - None ## QA Notes - The subject search widget on the registration overview page should work as-expected now - Registration admins editing the Registration's Metadata using the Metadata panel on the right should be able to search for subjects and apply those subjects onto the registration
21.9.0 A11y and other minor bug fixes
futa-ikeda
reviewed
Nov 9, 2021
futa-ikeda
reviewed
Nov 9, 2021
futa-ikeda
reviewed
Nov 9, 2021
Comment on lines
198
to
200
| {{#if this.shouldShowUpdateButton}} | ||
| {{#unless (not-eq this.node.reviewsState 'accepted')}} | ||
| {{#if this.latestSchemaResponse}} |
Contributor
There was a problem hiding this comment.
I think the template file looks correct right now the way it is. We may want to tweak some of the logic in the shouldShowUpdateButton computed property, but we can update those in the component.ts file. We will also need to add a new computed property called shouldShowLinkToUpdate in the component.ts file so a link to the existing revision in progress is shown appropriately:
{{#if this.shouldShowUpdateButton}}
<Button
{{on 'click' (perform this.createNewSchemaResponse)}}
disabled={{this.createNewSchemaResponse.isRunning}}
/>
{{else if this.shouldShowLinkToUpdate}}
<OsfLink
data-analytics-name='Update'
data-test-update-button='{{@node.id}}'
@route='registries.edit-revision.index'
@models={{array this.latestSchemaResponse.id}}
>
<Button
local-class='RegistrationCard_update'
>
{{t 'node_card.update_button'}}
</Button>
</OsfLink>
{{/if}}
^ some of the tabbing will need to be cleaned up, but the logic is sound
…ForOpenScience/ember-osf-web into feature/my-registrations-update-button Merging upstream changes.
Contributor
|
Closed in favor of #1346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this ticket was to add an update button to enable changes for versioning.
Summary of Changes
Screenshot(s)
Side Effects
QA Notes