CenterForOpenScience · chth0n1x · Sep 14, 2021 · Oct 4, 2021 · Oct 4, 2021 · Oct 4, 2021
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [21.9.0] - 2021-11-08
+### Changed
+- Misc a11y fixes
+- Removed RIDIE from registries dashboard
+- Replace help guide link on project registrations tab
+- Hide link to wiki on Registration overview page if registration has wiki disabled
+- Remove registration templates that are only for community oriented registries from the Registries Discover page registration-type facet
+- Fix registration overview page subjects search
+
 ## [21.8.0] - 2021-10-04
 ### Added
 - bulk upload component `Branded::Moderation::-Components::UploadCsv`
@@ -1801,7 +1810,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Added
 - Quick Files
 
-[Unreleased]: https://github.com/CenterForOpenScience/ember-osf-web/compare/21.7.0...develop
+[21.8.0]: https://github.com/CenterForOpenScience/ember-osf-web/releases/tag/21.9.0
+[21.8.0]: https://github.com/CenterForOpenScience/ember-osf-web/releases/tag/21.8.0
 [21.7.0]: https://github.com/CenterForOpenScience/ember-osf-web/releases/tag/21.7.0
 [21.6.3]: https://github.com/CenterForOpenScience/ember-osf-web/releases/tag/21.6.3
 [21.6.2]: https://github.com/CenterForOpenScience/ember-osf-web/releases/tag/21.6.2

diff --git a/app/guid-node/registrations/controller.ts b/app/guid-node/registrations/controller.ts
@@ -55,20 +55,15 @@ export default class GuidNodeRegistrations extends Controller {
         this.set('schemas', schemas);
     }
 
-    @computed('tab')
-    get activeTab() {
-        return this.tab ? this.tab : 'registrations';
-    }
-
     @computed('node.{id,root.id,root.userHasAdminPermission}')
     get isComponentRootAdmin() {
         return this.node && this.node.id !== this.node.root.get('id') && this.node.root.get('userHasAdminPermission');
     }
 
     @action
-    changeTab(activeId: string) {
-        this.set('tab', activeId === 'registrations' ? undefined : activeId);
-        this.analytics.click('tab', `Registrations tab - Change tab to: ${activeId}`);
+    changeTab(activeId: number) {
+        const tabName = activeId === 0 ? 'registrations' : 'drafts';
+        this.analytics.click('tab', `Registrations tab - Change tab to: ${tabName}`);
     }
 
     @action

diff --git a/app/guid-node/registrations/styles.scss b/app/guid-node/registrations/styles.scss
@@ -69,3 +69,43 @@ h4:global(.NewRegistrationModal__header) {
 :global(.PreRegChallengeModal__consent) {
     font-weight: normal;
 }
+
+.Tabs {
+    /* stylelint-disable selector-no-qualifying-type */
+    ul.TabList {
+        margin-bottom: 10px;
+        border-bottom: 1px solid #ddd;
+        box-sizing: border-box;
+        color: rgb(51, 51, 51);
+        display: block;
+        line-height: 20px;
+        list-style-image: none;
+        list-style-position: outside;
+        list-style-type: none;
+        height: 41px;
+        padding: 0;
+    }
+    /* stylelint-enable selector-no-qualifying-type */
+    .TabList {
+        li {
+            display: block;
+            position: relative;
+            margin-bottom: -1px;
+            float: left;
+            height: 41px;
+            padding: 10px 15px;
+        }
+
+        li:global(.ember-tabs__tab--selected) {
+            background-color: #f8f8f8;
+            border-bottom: 2px solid #204762;
+        }
+
+        li:hover {
+            border-color: transparent;
+            text-decoration: none;
+            background-color: #f8f8f8;
+            color: var(--primary-color);
+        }
+    }
+}
diff --git a/app/guid-node/registrations/template.hbs b/app/guid-node/registrations/template.hbs
@@ -8,16 +8,25 @@
 >
     <div class='row'>
         <div class='col-xs-9 col-sm-8'>
-            <BsTab
+            <AriaTabs
                 data-analytics-scope='Registrations Tab'
-                @activeId={{this.activeTab}}
-                @onChange={{action this.changeTab}}
+                @defaultIndex={{0}}
+                @onSelect={{action this.changeTab}}
+                local-class='Tabs'
                 as |tab|
             >
-                <tab.pane
-                    @id='registrations'
-                    @title={{t 'node.registrations.registrations'}}
+                <tab.tabList
+                    local-class='TabList'
+                    as |tablist|
                 >
+                    <tablist.tab>{{t 'node.registrations.registrations'}}</tablist.tab>
+                    {{#if this.node.userHasReadPermission}}
+                        <tablist.tab data-test-drafts-tab>
+                            {{t 'node.registrations.draft_registrations'}}
+                        </tablist.tab>
+                    {{/if}}
+                </tab.tabList>
+                <tab.tabPanel>
                     <div class='row' local-class='RegistrationsPane' data-test-registrations-pane>
                         <NodeList
                             @modelTaskInstance={{this.model.taskInstance}}
@@ -37,20 +46,16 @@
                                 {{/if}}
                                 <p>
                                     {{t 'node.registrations.learn_more'
-                                        learnMoreLink='https://openscience.zendesk.com/hc/en-us/articles/360019930893'
+                                        learnMoreLink='https://help.osf.io/hc/en-us/categories/360001550953-Registrations'
                                         htmlSafe=true
                                     }}
                                 </p>
                             </nl.empty>
                         </NodeList>
                     </div>
-                </tab.pane>
+                </tab.tabPanel>
                 {{#if this.node.userHasReadPermission}}
-                    <tab.pane
-                        data-analytics-scope='Drafts tab'
-                        @id='drafts'
-                        @title={{t 'node.registrations.draft_registrations'}}
-                    >
+                    <tab.tabPanel data-analytics-scope='Drafts tab'>
                         <div class='row' local-class='RegistrationsPane' data-test-draft-registrations-pane>
                             <PaginatedList::HasMany
                                 data-analytics-scope='Project Draft Registrations'
@@ -74,16 +79,16 @@
                                     {{/if}}
                                     <p>
                                         {{t 'node.registrations.learn_more'
-                                          learnMoreLink='https://openscience.zendesk.com/hc/en-us/articles/360019930893'
+                                          learnMoreLink='https://help.osf.io/hc/en-us/categories/360001550953-Registrations'
                                           htmlSafe=true
                                         }}
                                     </p>
                                 </list.empty>
                             </PaginatedList::HasMany>
                         </div>
-                    </tab.pane>
+                    </tab.tabPanel>
                 {{/if}}
-            </BsTab>
+            </AriaTabs>
         </div>
         {{#if this.node.userHasAdminPermission}}
             <div class='col-xs-3 col-sm-4'>

diff --git a/app/institutions/index/template.hbs b/app/institutions/index/template.hbs
@@ -3,6 +3,7 @@
 <div
     data-analytics-scope='Institutions'
     local-class='Institutions__page'
+    role='main'
 >
     <div
         data-test-insitutions-header
@@ -97,6 +98,7 @@
                                 {{#if this.hasMore}}
                                     <BsButton
                                         data-test-more-institutions
+                                        aria-label={{t 'institutions.load_more'}}
                                         data-analytics-name='Next page'
                                         local-class='Institutions__more'
                                         @type='link'

diff --git a/app/meetings/detail/-components/meeting-submissions-list/template.hbs b/app/meetings/detail/-components/meeting-submissions-list/template.hbs
@@ -4,6 +4,7 @@
             @type='text'
             @placeholder={{t 'meetings.index.meetings-list.search'}}
             @key-up={{perform this.searchSubmissions}}
+            aria-label={{t 'meetings.index.meetings-list.search'}}
         />
     </div>
 </div>
@@ -64,6 +65,7 @@
                 <div data-test-submissions-list-item-download>
                     {{#if submission.links.download}}
                         <BsButton
+                            aria-label={{t 'general.download'}}
                             @type='success'
                             class='btn-xs'
                             @onClick={{action this.downloadFile submission}}

diff --git a/app/meetings/index/-components/meetings-hero-banner/styles.scss b/app/meetings/index/-components/meetings-hero-banner/styles.scss
@@ -46,4 +46,10 @@
     h2 {
         font-size: 24px;
     }
+
+    .register-box {
+        a {
+            color: $color-link-dark;
+        }
+    }
 }
diff --git a/app/meetings/index/-components/meetings-hero-banner/template.hbs b/app/meetings/index/-components/meetings-hero-banner/template.hbs
@@ -43,7 +43,7 @@
                     </div>
                     <CpPanel @open={{this.registerPanelOpen}} as |panel| >
                         <panel.body>
-                            <div data-test-register-panel-text class='m-lg osf-box-lt p-md text-left'>
+                            <div data-test-register-panel-text class='m-lg osf-box-lt p-md text-left' local-class='register-box'>
                                 {{t 'meetings.index.meetings-hero-banner.conference_organizers_register_panel_texts' htmlSafe=true}}
                             </div>
                         </panel.body>

diff --git a/app/meetings/index/-components/meetings-list/template.hbs b/app/meetings/index/-components/meetings-list/template.hbs
@@ -5,6 +5,7 @@
 <div data-test-meetings-list-search local-class='search'>
     <div class='col-xs-12 col-sm-6 col-sm-offset-6'>
         <Input
+            aria-label={{t 'meetings.index.meetings-list.search'}}
             @type='text'
             @placeholder={{t 'meetings.index.meetings-list.search'}}
             @key-up={{perform this.searchMeetings}}

diff --git a/app/models/registration.ts b/app/models/registration.ts
@@ -105,6 +105,7 @@ export default class RegistrationModel extends NodeModel.extend(Validations) {
     @attr('fixstring') iaUrl?: string;
     @attr('array') providerSpecificMetadata!: ProviderMetadata[];
     @attr('fixstring') revisionState!: RevisionReviewStates;
+    @attr('boolean') wikiEnabled!: boolean;
 
     // Write-only attributes
     @attr('array') includedNodeIds?: string[];

diff --git a/app/styles/_components.scss b/app/styles/_components.scss
@@ -140,7 +140,7 @@
 }
 
 .osf-project-navbar li.active a {
-    color: #f8f8f8;
+    color: #fff;
 }
 
 .osf-project-navbar a.project-title {

diff --git a/lib/analytics-page/addon/components/analytics-charts/x-chart-wrapper/styles.scss b/lib/analytics-page/addon/components/analytics-charts/x-chart-wrapper/styles.scss
@@ -7,7 +7,7 @@
 
 .DisabledPanel {
     :global(.panel-title) {
-        color: $color-text-gray-light;
+        color: $color-text-black;
     }
 }
 

diff --git a/lib/app-components/addon/components/project-contributors/list/item/styles.scss b/lib/app-components/addon/components/project-contributors/list/item/styles.scss
@@ -37,11 +37,6 @@
     height: 30px;
 }
 
-.checkbox-label {
-    font-weight: normal;
-    padding-right: 5px;
-}
-
 @media (min-width: 768px) {
     .text-sm-center {
         text-align: center;

diff --git a/lib/app-components/addon/components/project-contributors/list/item/template.hbs b/lib/app-components/addon/components/project-contributors/list/item/template.hbs
@@ -58,13 +58,12 @@
     {{! Bibliographic (Citation) }}
     <div data-test-project-contributors-list-item-citation-checkbox local-class='text-sm-center'
         class='col-xs-10 col-sm-2 col-sm-offset-0 bib-padding'>
-        <label local-class='checkbox-label' class='visible-xs-inline' for='{{@contributor.id}}-citation'>
-            <em>
-                {{t 'app_components.project_contributors.list.item.in_citation_label'}}
-            </em>
-        </label>
-        <Input @id={{concat @contributor.id '-citation'}} @type='checkbox' @disabled={{not this.canChangeBibliographic}}
-            @checked={{@contributor.bibliographic}} @change={{action @toggleBibliographic @contributor}} />
+        <Input
+            aria-label={{t 'app_components.project_contributors.list.item.in_citation_label'}}
+            @type='checkbox'
+            @disabled={{not this.canChangeBibliographic}}
+            @checked={{@contributor.bibliographic}}
+            @change={{action @toggleBibliographic @contributor}} />
     </div>
 
     {{! Remove }}

diff --git a/lib/app-components/addon/components/project-contributors/search/template.hbs b/lib/app-components/addon/components/project-contributors/search/template.hbs
@@ -5,13 +5,15 @@
         class='input-group'
     >
         <Input
+            aria-label={{t 'app_components.project_contributors.search.placeholder'}}
             @class='form-control'
             @value={{this.query}}
             @placeholder={{t 'app_components.project_contributors.search.placeholder'}}
         />
         <span class='input-group-btn'>
             <button
                 data-test-project-contributors-search-button
+                aria-label={{t 'app_components.project_contributors.search.perform_search'}}
                 local-class='authors-search-button'
                 class='btn btn-default'
                 type='submit'

diff --git a/lib/app-components/addon/components/submit-section/active/styles.scss b/lib/app-components/addon/components/submit-section/active/styles.scss
@@ -1,5 +1,5 @@
 .closed {
-    color: #888;
+    color: $color-text-black;
 }
 
 .green {

diff --git a/lib/collections/addon/components/collection-search-result/node/template.hbs b/lib/collections/addon/components/collection-search-result/node/template.hbs
@@ -23,7 +23,7 @@
         <p>
             <div
                 data-test-collection-search-result-node-description
-                class='text-muted m-t-sm'>
+                class='m-t-sm'>
                 {{#if this.showBody}}
                     {{unescape-xml-entities this.item.description}}
                 {{else}}

diff --git a/...collections/addon/components/discover-page/active-filters/collection-provider/styles.scss b/...collections/addon/components/discover-page/active-filters/collection-provider/styles.scss
@@ -1,6 +1,6 @@
 .Component {
     span {
-        background-color: #578ca2;
-        color: #eee;
+        background-color: $color-bg-blue-darker;
+        color: $color-text-white;
     }
 }
diff --git a/lib/collections/addon/components/discover-page/active-filters/filter/template.hbs b/lib/collections/addon/components/discover-page/active-filters/filter/template.hbs
@@ -5,8 +5,9 @@
 >
     {{@text}}
     {{#unless @hide}}
-        <span aria-label={{@ariaLabel}}>
+        <span>
             <button
+                aria-label={{@ariaLabel}}
                 data-test-active-filter-remove-button
                 type='button'
                 local-class='removeActiveFilter'

diff --git a/lib/collections/addon/components/discover-page/template.hbs b/lib/collections/addon/components/discover-page/template.hbs
@@ -52,6 +52,10 @@
                     class='input-group input-group-lg'
                 >
                     <Input
+                        aria-label={{t
+                            (or this.searchPlaceholder 'collections.discover_page.searchPlaceholder')
+                            documentType=this.themeProvider.documentType
+                        }}
                         @id='searchBox'
                         @value={{this.q}}
                         @class='form-control'
@@ -111,7 +115,6 @@
                         {{this.sortDisplay}}
                         <span
                             class='caret'
-                            aria-label={{t 'collections.discover_page.sortSearchResults'}}
                             >
                         </span>
                     </dd.button>
@@ -202,14 +205,14 @@
                         {{!PROBLEM WITH SEARCH QUERY}}
                         <QuerySyntax @message={{this.queryError}} />
                     {{else if this.serverError}}
-                        <div class='text-muted text-center'>
+                        <div class='text-center'>
                             <p class='lead'>
                                 {{t 'collections.discover_page.searchUnavailable'}}
                             </p>
                         </div>
                     {{else}}
                         {{!NO RESULTS FOUND}}
-                        <div class='text-muted text-center'>
+                        <div class='text-center'>
                             <p class='lead'>
                                 {{t 'collections.discover_page.noResultsFound'}}
                             </p>

diff --git a/lib/osf-components/addon/components/files/list/styles.scss b/lib/osf-components/addon/components/files/list/styles.scss
@@ -5,7 +5,7 @@
     justify-content: center;
 
     height: 420px;
-    color: $color-text-gray-dark;
+    color: $color-black;
 }
 
 .list-container {