Skip to content

Call isRunning properly #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamescdavis merged 1 commit into from
Mar 26, 2018
Merged

Call isRunning properly #131

jamescdavis merged 1 commit into from
Mar 26, 2018

Conversation

@hmoco
Copy link
Contributor

@hmoco hmoco commented Mar 26, 2018

Purpose

Summary of Changes

Side Effects / Testing Notes

Ticket

https://openscience.atlassian.net/browse/EMB-

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@coveralls
Copy link

coveralls commented Mar 26, 2018

Coverage Status

Coverage remained the same at 21.122% when pulling 3053bca on hmoco:feature/EMB-110_waffle into b9e1cdc on CenterForOpenScience:develop.

jamescdavis
jamescdavis approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jamescdavis jamescdavis merged commit 77a8c53 into CenterForOpenScience:develop Mar 26, 2018
@jamescdavis jamescdavis added this to the 0.3.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jamescdavis jamescdavis jamescdavis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hmoco @coveralls @jamescdavis