[EMB-172] Fix all linter warnings and some TS errors #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescdavis
reviewed
Mar 28, 2018
| }, | ||
| }); | ||
| authenticate() { | ||
| return this._test(); |
Member
There was a problem hiding this comment.
So it doesn't actually have to be wrapped in an RSVP promise?
Contributor
Author
There was a problem hiding this comment.
I changed authenticatedAJAX to take care of that, since it was the source of the jQuery promise. Now no one else has to worry.
aaxelb
force-pushed
the
emb-172--no-warning
branch
from
9f3213c to
e3d80e3
Compare
Member
|
Muchos conflictos. Lo siento. :( |
Member
|
This is now mostly duplicated by #144. There may be some other useful stuff here that we might want to include in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix all linter warnings and consider them unacceptable from now on.
Summary of Changes
--max-warnings=0to eslint invocations in.travis.ymlandpackage.json, so warnings behave like errors on travis and pre-commit hooksSide Effects / Testing Notes
This touched lots of things but shouldn't have changed any. Warrants a regression test.
Ticket
https://openscience.atlassian.net/browse/EMB-172
Reviewer Checklist
CHANGELOG.md