[ENG-3511] Fix analytics page linked projects list #1646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does this need to be a hotfix? |
Pull Request Test Coverage Report for Build 2972833972
💛 - Coveralls |
Contributor
Author
|
Nah. It's been broken for forever and was a medium-priority ticket. |
adlius
approved these changes
Sep 1, 2022
Contributor
adlius
left a comment
adlius
left a comment
There was a problem hiding this comment.
Didn't know the analytic page is an engine.
chth0n1x
pushed a commit
to chth0n1x/ember-osf-web
that referenced
this pull request
Feb 1, 2023
…e#1646) - Ticket: [ENG-3511] ## Purpose The linked projects list in the project analytics engine wasn't rendering. It looks like, sometime after we implemented the list, we added the toast and current-user services to the node-card (or something in the node-card chain). Those services weren't in the analytics engine, so the rendering of the node-card broke. This corrects that problem. ## Summary of Changes 1. Add missing services to engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The linked projects list in the project analytics engine wasn't rendering. It looks like, sometime after we implemented the list, we added the toast and current-user services to the node-card (or something in the node-card chain). Those services weren't in the analytics engine, so the rendering of the node-card broke. This corrects that problem.
Summary of Changes
Screenshot(s)
Side Effects
Nah.