Skip to content

Conversation

@adlius
Copy link
Contributor

@adlius adlius commented Sep 6, 2022

  • Ticket: []
  • Feature flag: n/a

Purpose

Fix the problem where file kebab button have inconsistent spacing for folder items and file items.
Hide file download count for external providers.

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. The helper could stand to have two small tests for it though. And fix the broken tests, of course.

@coveralls
Copy link

coveralls commented Sep 8, 2022

Pull Request Test Coverage Report for Build 3039860499

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 71.315%

Totals Coverage Status
Change from base Build 3039860184: 0.01%
Covered Lines: 5388
Relevant Lines: 7341

💛 - Coveralls

@futa-ikeda futa-ikeda added this to the 22.9.0 milestone Sep 12, 2022
@brianjgeiger brianjgeiger merged commit 905a40a into CenterForOpenScience:develop Sep 12, 2022
chth0n1x pushed a commit to chth0n1x/ember-osf-web that referenced this pull request Feb 1, 2023
## Purpose

Fix the problem where file kebab button have inconsistent spacing for folder items and file items.
Hide file download count for external providers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants