This repository was archived by the owner on Apr 14, 2026. It is now read-only.
[ENG-4409] Added new formatting to the dashboard-item#1818
Merged
brianjgeiger merged 1 commit intoCenterForOpenScience:basket/telluriumfrom Mar 20, 2023
Merged
Conversation
brianjgeiger
approved these changes
Mar 15, 2023
Contributor
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
Looks great! Much cleaner code, and fewer bootstraps.
Pull Request Test Coverage Report for Build 4428246251
💛 - Coveralls |
adlius
approved these changes
Mar 15, 2023
futa-ikeda
approved these changes
Mar 15, 2023
Contributor
futa-ikeda
left a comment
futa-ikeda
left a comment
There was a problem hiding this comment.
Looks good! It looks like .di-date and .di-contributors aren't adding any styling rules, but this is more of a nit
bp-cos
added a commit
to bp-cos/ember-osf-web
that referenced
this pull request
Mar 21, 2023
## Purpose To remove dependency on Bootstrap ## Summary of Changes Removed all the bootstrap from the dashboard-item component
bp-cos
added a commit
to bp-cos/ember-osf-web
that referenced
this pull request
Mar 30, 2023
## Purpose To remove dependency on Bootstrap ## Summary of Changes Removed all the bootstrap from the dashboard-item component
bp-cos
added a commit
to bp-cos/ember-osf-web
that referenced
this pull request
May 18, 2023
## Purpose To remove dependency on Bootstrap ## Summary of Changes Removed all the bootstrap from the dashboard-item component
chth0n1x
pushed a commit
to chth0n1x/ember-osf-web
that referenced
this pull request
May 31, 2023
## Purpose To remove dependency on Bootstrap ## Summary of Changes Removed all the bootstrap from the dashboard-item component
chth0n1x
pushed a commit
to chth0n1x/ember-osf-web
that referenced
this pull request
May 31, 2023
## Purpose To remove dependency on Bootstrap ## Summary of Changes Removed all the bootstrap from the dashboard-item component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
To remove dependency on Bootstrap
Summary of Changes
Removed all the bootstrap from the dashboard-item component
Screenshot(s)
Pre-desktop and pre-mobile
Post-desktop and post-mobile
Side Effects
A million probably
QA Notes
There will be some minor issues like columns not lining up because I fixed the child and not the parent. This is will be resolved over time. There is also a change between the mobile layout margins.