Address bugs in file-detail page #2049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
approved these changes
Nov 10, 2023
adlius
pushed a commit
that referenced
this pull request
Nov 10, 2023
* [WIP] first stab at Boa addon ux * make boa modal findable * save WIP on dataset select * futa wisdom attained/accepted * add action; fetch parents properly * enabled addons enabled * cleanups; fix closemodal * Add mirage support for BoA files * Type updates * authenticate addon endpoint request * Add a bit of error handling to mirage * Change logic to populate a node addons * Disable submit to boa if no dataset selected * Add qp to boa upload link * Add placeholder message to dataset select * Update toast messages * CR feedback * Boa bugs (#2047) * Add file size to boa request * Allow checked out boa file to be submitted * Use sizeInt * Circumvent promise-induced bugs (#2049) --------- Co-authored-by: Fitz Elliott <fitz@cos.io> Co-authored-by: Futa Ikeda <futa.ikeda@gmail.com> Co-authored-by: futa-ikeda <51409893+futa-ikeda@users.noreply.github.com>
bp-cos
pushed a commit
to bp-cos/ember-osf-web
that referenced
this pull request
Jan 31, 2024
) * [WIP] first stab at Boa addon ux * make boa modal findable * save WIP on dataset select * futa wisdom attained/accepted * add action; fetch parents properly * enabled addons enabled * cleanups; fix closemodal * Add mirage support for BoA files * Type updates * authenticate addon endpoint request * Add a bit of error handling to mirage * Change logic to populate a node addons * Disable submit to boa if no dataset selected * Add qp to boa upload link * Add placeholder message to dataset select * Update toast messages * CR feedback * Boa bugs (CenterForOpenScience#2047) * Add file size to boa request * Allow checked out boa file to be submitted * Use sizeInt * Circumvent promise-induced bugs (CenterForOpenScience#2049) --------- Co-authored-by: Fitz Elliott <fitz@cos.io> Co-authored-by: Futa Ikeda <futa.ikeda@gmail.com> Co-authored-by: futa-ikeda <51409893+futa-ikeda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(https://www.notion.so/cos/Submit-to-Boa-not-present-on-file-detail-page-4366c4f5864147c8bd7d6338b9e003d3?pvs=4)
Purpose
Summary of Changes
parentFolder.userCanUploadToHereas this was causing issues due to some unresolved promises (targetspecifically)showSubmitToBoawill now basically do the same check asuserCanUploadToHeresansthis.isFolderconditionScreenshot(s)
Side Effects
QA Notes