Skip to content

Conversation

@baylee-d
Copy link

@baylee-d baylee-d commented Dec 7, 2017

Purpose

If users do not have JavaScript enabled on their browser, ember-osf pages are displayed as blank white pages. This will add an error message on the page that lets the user know what is happening and how to enable JavaScript to use the site.

Summary of Changes

  • Added <noscript> message

screen shot 2017-12-07 at 2 21 27 pm

Ticket

https://openscience.atlassian.net/browse/EOSF-889

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md (don't have initial release yet)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 6.931% when pulling 1a6bfb4 on baylee-d:feature/add-no-javascript-message into b3b7fa0 on CenterForOpenScience:develop.

Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 ☕️

@jamescdavis jamescdavis merged commit 8abbcc0 into CenterForOpenScience:develop Dec 14, 2017
@baylee-d baylee-d deleted the feature/add-no-javascript-message branch January 17, 2018 15:56
@jamescdavis jamescdavis added this to the 0.1.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants