[EMB-610] Add query parameter. #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2790
💛 - Coveralls |
aaxelb
requested changes
Apr 2, 2019
| @computed('signUpURL', 'signUpNext') | ||
| get signUpRoute() { | ||
| return this.features.isEnabled(featureFlagNames.routes.register) ? 'register' : | ||
| return this.features.isEnabled(featureFlagNames.routes.register) ? `register?${param(this.signUpQueryParams)}` : |
Contributor
There was a problem hiding this comment.
While this fixes the immediate problem, a better solution would be deleting the signUpRoute computed prop entirely and replacing the @href here with @route='register':
For several reasons:
- Would fix a bug I happened to find while testing this: Clicking "Sign up" on the registries discover page takes you to
/registries/register(becausehref='register'is a relative URL), which 404s (verified on prod) - Using OsfLink's
@routeinstead of@hrefavoids reloading the page when the emberized sign up page is waffled on - Feature flags are checked on every transition, so the check here is redundant
Looks like signUpURL is never used, so that should be a safe change (and signUpURL could be deleted too).
aaxelb
previously approved these changes
Apr 17, 2019
jamescdavis
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add
campaignquery parameter to register view's url.QA Notes
campaign=osf-registriesshould appear in the url when you sign up through registries landing page.Ticket
https://openscience.atlassian.net/browse/EMB-610
Reviewer Checklist
CHANGELOG.md