Add Japanese and Egyptian languages#184
Closed
Johnetordoff wants to merge 18 commits intoCenterForOpenScience:developfrom
Closed
Add Japanese and Egyptian languages#184Johnetordoff wants to merge 18 commits intoCenterForOpenScience:developfrom
Johnetordoff wants to merge 18 commits intoCenterForOpenScience:developfrom
Conversation
Johnetordoff
changed the title
…into add-egyptian-japanese * 'develop' of https://github.com/CenterForOpenScience/isp: (59 commits) bump version further corrections for finnish translation fix typo in Finnish translation release Swedish to production bump version manually fix an error in the Dutch translation clarify translation-generation instructions add translation template need to generate translations Updates for ISP 1.0.20 intercept, tag, and log 'Could not save data' errors update exp-addons commit for better error messaging bump version Updates for ISPv1.0.19 bump version Translations for ISPv1.0.18 bump version Updates for ISPv1.0.17 update exp-addons dep to use larger page sizes update exp-addons dep to get green Cat9 labels Bump release version ... # Conflicts: # app/locales/ja/translations.js
…ff/isp into add-egyptian-japanese * 'add-egyptian-japanese' of https://github.com/Johnetordoff/isp: remove all idea files remove .idea file remove old Japanese consent form add Japanese and Egyptian
…ff/isp into add-egyptian-japanese
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://openscience.atlassian.net/browse/SVCS-618
Purpose
This adds Japanese and Egyptian Arabic as selectable languages
Summary of changes
Testing notes
I ran unit tests on this and they passed.