[SVCS-583] Clean up and update dockerfile #297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binoculars
force-pushed
the
feature/update-dockerfile
branch
from
09ea58f to
191b339
Compare
cslzchen
reviewed
Nov 9, 2017
Contributor
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
@binoculars thanks! LGTM. Let me test a local build first. 🎆 🎆
cslzchen
changed the title
cslzchen
approved these changes
Nov 10, 2017
Contributor
|
Locally build successfully with negligible warnings. 🎆 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/SVCS-583
Purpose
N/A
Changes
N/A
Side effects
N/A
QA Notes
DevOps will test this on the jenkins side once merged.
Deployment Notes
N/A