[ENG-7707] A specific preprint is not found but should be #11059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
approved these changes
Mar 27, 2025
Comment on lines
657
to
662
| res = self.app.get(f'/{API_BASE}preprints/{self.pre_mod_preprint._id.split('_')[0]}/', auth=self.moderator.auth, expect_errors=True) | ||
| assert res.status_code == 200 | ||
|
|
||
| # preprint version | ||
| res = self.app.get(f'/{API_BASE}preprints/{pre_mod_preprint_v2._id}/', auth=self.moderator.auth, expect_errors=True) | ||
| assert res.status_code == 200 |
Collaborator
There was a problem hiding this comment.
If you're getting a status of 200 back, you shouldn't be expecting_errors.
brianjgeiger
requested changes
Mar 27, 2025
Collaborator
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
Please update your tests not to expect errors when you aren't expecting errors.
brianjgeiger
approved these changes
Mar 28, 2025
brianjgeiger
merged commit 0ba47a9
into
CenterForOpenScience:feature/pbs-25-05
6 checks passed
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
Mar 31, 2025
…cience/osf.io into fix-preprint-dois * 'feature/pbs-25-05' of https://github.com/CenterForOpenScience/osf.io: [ENG-7707] A specific preprint is not found but should be (CenterForOpenScience#11059) [ENG-7461] Fix Validation Issues with Article DOIs (CenterForOpenScience#11062) [ENG-6422] added management command to log all write actions to given table (CenterForOpenScience#11057) add CSRF protection and throttle classes; update tests refactor external login serializer and view to use session data for user information add external login unit tests removed campaigns fix tests Add external login serializer and view for first-time OAuth users # Conflicts: # api/preprints/serializers.py # api_tests/preprints/views/test_preprint_detail.py
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
Apr 11, 2025
into develop * 'develop' of https://github.com/CenterForOpenScience/osf.io: (61 commits) Update changelog and package.json [ENG-7698] Fix permission for contributor, when accepting access request #2 (CenterForOpenScience#11077) Add disable meetings feature Fix institutional access request for contributor upgrade cache and ubuntu versions to avoid GHA brownouts (CenterForOpenScience#11009) [ENG-7461] Fix bug with Article DOI for Preprints (CenterForOpenScience#11068) [ENG-7472] Fix/preprint no option to resubmit (CenterForOpenScience#11069) [ENG-7714] Use retry instead of sleep (CenterForOpenScience#11067) Implement flag to disable comment updates and add corresponding tests [ENG-7707] A specific preprint is not found but should be (CenterForOpenScience#11059) Add feature flag to disable comments and update related tests [ENG-7461] Fix Validation Issues with Article DOIs (CenterForOpenScience#11062) [ENG-6422] added management command to log all write actions to given table (CenterForOpenScience#11057) add CSRF protection and throttle classes; update tests refactor external login serializer and view to use session data for user information add external login unit tests removed campaigns fix tests Add external login serializer and view for first-time OAuth users Fix permission for contributor, when accept access request ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Show preprints in public states
Changes
It's possible that Review Action was not created for published preprint (see
Preprint.set_published()function for more details). This change will consider public states for different workflows instead of only filtering by review actions for pre-moderation workflowQA Notes
The easiest way to recreate this bug I was able to found is to create preprint via website, but not submitting it. Instead, go to the admin panel of the preprint and hit "Make published" button. It'll make preprint published with machine state 'accepted', but won't create review action for it. Such preprint will be visible only for provider moderators if provider review workflow is not None. I think there may be some other ways to recreate it (suspect any PATCH /v2/preprints/<preprint_id> request with published=True)
All of that sould be fixed with this PR
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-7707