[ENG-7503] - Fix user unable to edit OR create new version of a preprint #11060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/preprints/serializers.py
Outdated
| ) | ||
|
|
||
| if updated_has_data_links != 'no' and updated_why_no_data: | ||
| if updated_has_data_links != 'no': |
Collaborator
There was a problem hiding this comment.
I managed to reproduce this problem locally by manually changing the database record, but the problem still exists, I believe this is the right solution.
Suggested change
| if updated_has_data_links != 'no': | |
| if updated_has_data_links != 'no' and updated_why_no_data and validated_data.get('data_links'): |
Contributor
Author
There was a problem hiding this comment.
Removed these changes
Vlad0n20
changed the title
Johnetordoff
requested changes
Apr 3, 2025
Contributor
Johnetordoff
left a comment
Johnetordoff
left a comment
There was a problem hiding this comment.
Looks good, just write a few different test cases to the osf_tests/management_commands/ directory. To make clear what use case of this is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix preprint updating
Changes
Add a manage command to fix why_no_data and has_data_links for broken preprints due to an unknown bug on FE (Futa described it in the comments to the ticket)
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-7503?atlOrigin=eyJpIjoiZWYyNDhjYjBiMWY5NDhjNGEyODdiOTgwMmE1YzlhNTciLCJwIjoiaiJ9