[ENG-7749] admin user can publish preprint in admin app even if he isn't a contributor #11084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
requested changes
Apr 9, 2025
Collaborator
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
Looks good, just one small change for readability.
admin/preprints/views.py
Outdated
| def post(self, request, *args, **kwargs): | ||
| preprint = self.get_object() | ||
| preprint.set_published(True, request, True) | ||
| preprint.set_published(True, request, True, True) |
Collaborator
There was a problem hiding this comment.
That's a lot of unlabeled args there. Could you replace those with kwargs so it's more clear what's going on?
brianjgeiger
approved these changes
Apr 9, 2025
brianjgeiger
merged commit f4d06dd
into
CenterForOpenScience:feature/pbs-25-07
6 checks passed
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
Apr 11, 2025
…cience/osf.io into remove-registration-metadata * 'feature/pbs-25-07' of https://github.com/CenterForOpenScience/osf.io: [ENG-7289] Fix Search Index Discrepancy in Collection Facets (CenterForOpenScience#11085) [ENG-7750] Preprint creator cannot remove bibliographic citation status (CenterForOpenScience#11087) [ENG-7799] Update authors' names format in metadata (CenterForOpenScience#11091) [ENG-5751] remove old keen logic (CenterForOpenScience#11082) [ENG-7751] Fixed contributors reordering on registration metadata page (CenterForOpenScience#11083) [ENG-7749] admin user can publish preprint in admin app even if he isn't a contributor (CenterForOpenScience#11084) [ENG-7761] Edit scopes with Personal Access Tokens (CenterForOpenScience#11081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
set_publishedmethod checks if this action is performed by admin contributor, however admins in admin app should be able to perform this action without the permissionChanges
Handle this case with an additional parameter in method because if we add check like "if is_admin or is_admin_contributor" there may be a case when admin user opens preprint and publishes it via API that he shouldn't be able to do
Ticket
https://openscience.atlassian.net/jira/software/c/projects/ENG/boards/145/backlog?assignee=712020%3A7c7368dc-40cb-475f-bae8-b07a8bd2dd6c&selectedIssue=ENG-7749