[ENG-7799] Update authors' names format in metadata #11091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
approved these changes
Apr 11, 2025
brianjgeiger
merged commit af28216
into
CenterForOpenScience:feature/pbs-25-07
6 checks passed
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
Apr 11, 2025
…cience/osf.io into remove-registration-metadata * 'feature/pbs-25-07' of https://github.com/CenterForOpenScience/osf.io: [ENG-7289] Fix Search Index Discrepancy in Collection Facets (CenterForOpenScience#11085) [ENG-7750] Preprint creator cannot remove bibliographic citation status (CenterForOpenScience#11087) [ENG-7799] Update authors' names format in metadata (CenterForOpenScience#11091) [ENG-5751] remove old keen logic (CenterForOpenScience#11082) [ENG-7751] Fixed contributors reordering on registration metadata page (CenterForOpenScience#11083) [ENG-7749] admin user can publish preprint in admin app even if he isn't a contributor (CenterForOpenScience#11084) [ENG-7761] Edit scopes with Personal Access Tokens (CenterForOpenScience#11081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In metadata we return authors' names as full names. We should use this format instead: "{family name}, {given name}"
Also added givenName and familyName in JSON-LD schema
Changes
Updated function that generates names, added
given_nameattribute when serialize contributors in mako templatesTicket
https://openscience.atlassian.net/browse/ENG-7799