[ENG-8320] Add Brand relationship to Collection Provider#11230
Merged
Johnetordoff merged 1 commit intoCenterForOpenScience:feature/pbs-25-13from Jul 17, 2025
Merged
Conversation
Johnetordoff
force-pushed
the
add-brand-to-collection-provider
branch
from
d34f08f to
914e7b9
Compare
Johnetordoff
force-pushed
the
add-brand-to-collection-provider
branch
from
7404916 to
99e26cb
Compare
futa-ikeda
reviewed
Jul 16, 2025
Contributor
futa-ikeda
left a comment
futa-ikeda
left a comment
There was a problem hiding this comment.
Seems like this would address the issue the angular team was having. Will leave proper review for someone a little better versed in API stuff though
felliott
reviewed
Jul 17, 2025
|
|
||
| brand = RelationshipField( | ||
| related_view='brands:brand-detail', | ||
| related_view_kwargs={'brand_id': '<brand.id>'}, |
Member
There was a problem hiding this comment.
This might be fine, but just to confirm: should this be ._id? I don't know Django all that well, but it seems like we lean towards using _id as the id field name in most places.
Contributor
Author
There was a problem hiding this comment.
We did not go so far as to add underscore ids to brands, it's not in the data model. There's the other providers use the bare .id for brands, so I believe it's okay.
Johnetordoff
merged commit 82cdfff
into
CenterForOpenScience:feature/pbs-25-13
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
Add brand relations to collection provider like the registration and preprint provider.
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-8320