Skip to content

Conversation

@Vlad0n20
Copy link
Contributor

@Vlad0n20 Vlad0n20 commented Nov 3, 2025

Purpose

Fix 502s when trying to make it public

Changes

Add exception for DOI creation

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-9651?atlOrigin=eyJpIjoiMGM1NGJkY2ZiOWQ0NGM1MjkwMjk2MDg0N2QyM2Q1OWEiLCJwIjoiaiJ9

Copy link
Collaborator

@Ostap-Zherebetskyi Ostap-Zherebetskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but we need to verify whether we want to allow the DOI creation process to be skipped.

Copy link
Collaborator

@Ostap-Zherebetskyi Ostap-Zherebetskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cslzchen cslzchen changed the base branch from feature/pbs-25-21 to hotfix/25.18.2 December 10, 2025 15:34
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I am only able to cherry-pick 3 of the 4 commits.

Image

Here is my local logs

(osf-3.12) ➜  osf git:(fix/ENG-9651) git rh upstream/master
HEAD is now at dd2174118f Merge branch 'hotfix/25.18.1'
(osf-3.12) ➜  osf git:(fix/ENG-9651) git cp b0cddf7afb7e8cfb1b393ac463adf4acdd466622
[fix/ENG-9651 58305fe956] Fix 502s when trying to make it public
 Author: Vlad0n20 <vlad.onischuk1234@gmail.com>
 Date: Mon Nov 3 16:47:14 2025 +0200
 2 files changed, 31 insertions(+), 5 deletions(-)
(osf-3.12) ➜  osf git:(fix/ENG-9651) git cp fb03f689b5e8f73de8c1fcef381da11cd0aa15c7
[fix/ENG-9651 dce53ea43e] Update except block for get_identifier_value
 Author: Vlad0n20 <vlad.onischuk1234@gmail.com>
 Date: Tue Nov 4 16:51:18 2025 +0200
 2 files changed, 30 insertions(+), 7 deletions(-)
(osf-3.12) ➜  osf git:(fix/ENG-9651) git cp 5eaf939893777dcd6f3217a1bf1a17f612d4387f
On branch fix/ENG-9651
You are currently cherry-picking commit 5eaf939893.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

nothing to commit, working tree clean
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
(osf-3.12) ➜  osf git:(fix/ENG-9651) git hist
(osf-3.12) ➜  osf git:(fix/ENG-9651) git status
On branch fix/ENG-9651
You are currently cherry-picking commit 5eaf939893.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

nothing to commit, working tree clean
(osf-3.12) ➜  osf git:(fix/ENG-9651) git cp 7dc15f6bc4a3ff6aa1bcc979e225cb71385cdeb8
[fix/ENG-9651 a5447ff63e] Add admin loging if DOI creation failed
 Author: Vlad0n20 <vlad.onischuk1234@gmail.com>
 Date: Wed Nov 5 17:16:15 2025 +0200
 3 files changed, 45 insertions(+), 14 deletions(-)
(osf-3.12) ➜  osf git:(fix/ENG-9651) git hist

Here is the diff of the dropped commit, which I confirmed locally it's no longer needed because it was probably removed by other PRs that was merged earlier.

Screenshot 2025-12-11 at 14 43 53

@cslzchen cslzchen merged commit fbce3ab into CenterForOpenScience:hotfix/25.18.2 Dec 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants