Skip to content

[feature] Improve Dashboard Wrapping [OSF-6539]#7470

Open
Rheisen wants to merge 5 commits intoCenterForOpenScience:developfrom
Rheisen:feature/OSF-6539_Improve_Dashboard_Wrapping
Open

[feature] Improve Dashboard Wrapping [OSF-6539]#7470
Rheisen wants to merge 5 commits intoCenterForOpenScience:developfrom
Rheisen:feature/OSF-6539_Improve_Dashboard_Wrapping

Conversation

@Rheisen
Copy link
Copy Markdown
Contributor

@Rheisen Rheisen commented Jul 17, 2017

Purpose

The dashboard contributor names would cause line breakages and weren't uniformly formatted, so this tries to improve the dashboard aesthetic by improving the contributor name formatting.

Changes

Improved how contributor names are listed to be more uniform and remain on a single line.

Before:
before

After:
after

Side effects

Modifies contribNameFormat in osfHelpers, so other pages that use it will also get the new formatting. (found in newAndNoteworthyPlugin.js, quickProjectSearchPlugin.js, home-page.js)

QA considerations

General formatting style is different for single contribs, two contribs, and more than two contribs.

  • Making sure this won't leave trailing spaces
  • Making sure the second contrib name shows enough characters when being used
  • Making sure the count is correct for the number of additional contribs not being displayed

Ticket

https://openscience.atlassian.net/browse/OSF-6539

Copy link
Copy Markdown
Contributor

@alexschiller alexschiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After image looks fine to me-- will do a thorough review once product approves the changes. Per discussion with Rheisen, he will add tests after product review to not duplicate work in case of major changes.

 into feature/OSF-6539_Improve_Dashboard_Wrapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants