[feature] Improve Dashboard Wrapping [OSF-6539]#7470
Open
Rheisen wants to merge 5 commits intoCenterForOpenScience:developfrom
Open
[feature] Improve Dashboard Wrapping [OSF-6539]#7470Rheisen wants to merge 5 commits intoCenterForOpenScience:developfrom
Rheisen wants to merge 5 commits intoCenterForOpenScience:developfrom
Conversation
Contributor
alexschiller
left a comment
There was a problem hiding this comment.
After image looks fine to me-- will do a thorough review once product approves the changes. Per discussion with Rheisen, he will add tests after product review to not duplicate work in case of major changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The dashboard contributor names would cause line breakages and weren't uniformly formatted, so this tries to improve the dashboard aesthetic by improving the contributor name formatting.
Changes
Improved how contributor names are listed to be more uniform and remain on a single line.
Before:

After:

Side effects
Modifies contribNameFormat in osfHelpers, so other pages that use it will also get the new formatting. (found in newAndNoteworthyPlugin.js, quickProjectSearchPlugin.js, home-page.js)
QA considerations
General formatting style is different for single contribs, two contribs, and more than two contribs.
Ticket
https://openscience.atlassian.net/browse/OSF-6539