[Feature] Cursor based pagination [#OSF-8565]

[mfraezz]

Purpose

Improve NodeLogList performance

Changes

• Create JSONAPI-compliant subclass for rest_framework.pagination.CursorPagination
• Use on NodeLogList
• Update frontend

Side effects

None expected

Ticket

[OSF-8565]

[sloria]

This is a pretty significant, backwards-incompatible change (worthy of more than a minor version bump). I wonder if we should keep the current pagination scheme to preserve compat but allow changing the pagination style via a query parameter. Looks like there's even a package for that.

Thoughts, @brianjgeiger ?

[sloria]

The loading indicator for the log feed got lost with this change.

That said, the log feed was using the now-deprecated OSF loading spinner. Two options:

• Good: Update the log feed to use a new spinner (.ball-pulse).
• Better: Use a skeleton screen as a loading indicator. A quick-and-dirty way to achieve this is to reduce the opacity of the items when the widget is in the loading state. It's not exactly the same as a skeleton, but at least it doesn't change the height of the widget as much:

[sloria]

Pass finished for now. See if you can fix the loading indicator for now. We'll discuss whether or not to keep backwards compat for the paging style.

[mfraezz]

According to discussion with @brianjgeiger sometime over the past two weeks, this does not merit an API version bump. The values for linked references change, yes, but the rationale is that the client should only be following the resp.json['links'], the references for which do not change. That is, client-side url construction is not a supported use case; they should be using links provided in the response.

I'll fix the loading UI

[sloria]

@mfraezz Ah ok, thanks for the clarification. I wasn't sure if the keys of the pagination object were changing here or not. If not, then I agree: no need to bump versions.

Requested changes addressed