Pass strong-typed StoragePath instead of string to methods#87
Merged
pdeffendol merged 5 commits intomainfrom Sep 26, 2024
Merged
Pass strong-typed StoragePath instead of string to methods#87pdeffendol merged 5 commits intomainfrom
pdeffendol merged 5 commits intomainfrom
Conversation
Instead of using a string type for storage paths, switch to a non-primitive type StoragePath. This lets us encapsulate several of the operations needed for paths. All storage operations now take a StoragePath parameter. This can be converted to and from a string implicitly, so it's likely that existing code will work without modification, but for safety this should be a major version bump. +semver:breaking
Renamed some test methods to standardize terminology
pdeffendol
changed the title
Fixed a couple missed ".WithoutLeadingSlash" uses on the Rename methods
williamchamberlinCenteva
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This replaces the
stringparameter withStoragePathwhich has better typing and encapsulation. It shouldn't break existing usages because there are implicit string conversions.What type of PR is this? (check all applicable)
Quality Checklist