feat(v2): add TwoButtonsGestureDetector for L+R long-press#87
Merged
Conversation
kawinie
force-pushed
the
feat/v2-two-buttons-gesture
branch
3 times, most recently
from
b26ebd7 to
3238a6e
Compare
kawinie
changed the title
Returns the time passed to the last `set()`. Lets the owner read the arming timestamp without tracking it separately.
ButtonGestureDetector owns the press lifecycle. New
TwoButtonsGestureDetector fires on L+R simultaneous long-press and
publishes it as ButtonEvent{ButtonId::L_R, Gesture::LONG}. Also renames
POST_LONG to LATCHED and tweaks clang-format.
kawinie
force-pushed
the
feat/v2-two-buttons-gesture
branch
from
3238a6e to
5c8226c
Compare
kawinie
changed the title
2 tasks
centydev
approved these changes
May 14, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
TwoButtonsGestureDetectorthat fires on L+R simultaneous long-press and publishesButtonEvent{ButtonId::L_R, Gesture::LONG}so callers can reuse the existing variant.tempo::TimeoutTimergainsset_ms()so detectors read the arming timestamp from the timer. Also renamesPOST_LONGtoLATCHEDfor parity, updates state diagrams, and switches.clang-formatAlignAfterOpenBrackettoBlockIndent.Linked issues
Hardware tested
How tested:
pio test -e native(115 cases pass).pio run -e HW1_3_V2builds clean.Breaking change / migration
lib/*headers)Details:
tempo::TimeoutTimergains aset_ms()accessor. Additive, no existing callers affected.Notes