fix: Use cropped image dimensions for NDViewer configuration#498
Merged
Alpaca233 merged 2 commits intoFeb 27, 2026
Conversation
NDViewer was being configured with camera resolution from get_resolution(), but actual images are cropped via get_crop_size() in _process_raw_frame(). This caused a dimension mismatch where the viewer expected larger images than what was actually saved. Now uses get_crop_size() to get the actual image dimensions after software cropping, falling back to get_resolution() only if no crop is configured. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Alpaca233
force-pushed
the
fix/ndviewer-crop-dimensions
branch
from
84ea598 to
214a52b
Compare
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_crop_size()instead ofget_resolution()to get actual image dimensions after croppingProblem
NDViewer was being configured with camera resolution from
get_resolution(), but actual images are cropped viaget_crop_size()in_process_raw_frame(). This caused the viewer to expect larger images than what was actually saved, resulting in display issues.Test plan
🤖 Generated with Claude Code