Skip to content
This repository was archived by the owner on Jan 14, 2026. It is now read-only.

fix: use source schema to find time column instead of projected schema#16

Merged
Rachelint merged 3 commits intomainfrom
fix-schema
Mar 5, 2024
Merged

fix: use source schema to find time column instead of projected schema#16
Rachelint merged 3 commits intomainfrom
fix-schema

Conversation

@jiacai2050
Copy link
Member

@jiacai2050 jiacai2050 commented Mar 5, 2024

See apache/horaedb#1445

Projected schema may not contain all column used in query, such as:

select a from table where b > 1;

Only a is in projected schema.

Copy link
Member

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 05a8a9f into main Mar 5, 2024
Rachelint pushed a commit to apache/horaedb that referenced this pull request Mar 6, 2024
## Rationale
When time column is not in `select`, `extract_time_range` will not find
time range of one query

## Detailed Changes
- CeresDB/influxql#16

## Test Plan
CI
zealchen pushed a commit to zealchen/incubator-horaedb that referenced this pull request Apr 9, 2024
## Rationale
When time column is not in `select`, `extract_time_range` will not find
time range of one query

## Detailed Changes
- CeresDB/influxql#16

## Test Plan
CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants