Niv/cert 8958 add require reasoning #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks fine by me, @christiane-certora can you please let us know if this is the correct approach here? |
christiane-certora
approved these changes
May 15, 2025
Contributor
christiane-certora
left a comment
christiane-certora
left a comment
There was a problem hiding this comment.
Looks good to me, this is the example linked for the require statement in the docs and the explanations seem reasonable.
nd-certora
approved these changes
May 18, 2025
yoav-el-certora
added a commit
that referenced
this pull request
May 18, 2025
* Niv/cert 8248 revert example (#155) * CERT 8248 Add Revert Example * Update README * Address Christiane review * Update example based on Nurit Review * Clean * Update config.yml (#160) Co-authored-by: yoav-el-certora <122207807+yoav-el-certora@users.noreply.github.com> * Example ready * christiane cr * Code reviews * Config inheritance Example (#168) * Config inheritance Example * Update example based on review * CERT add invalid base conf * Update base.conf * CR comment * Update CVLByExample/ConfInheritance/invalid_base.conf Co-authored-by: urikirsh <38188877+urikirsh@users.noreply.github.com> * Fix invalid example --------- Co-authored-by: urikirsh <38188877+urikirsh@users.noreply.github.com> * Niv/cert 8958 add require reasoning (#172) * Add reasoning for require example * Address Nurit comments --------- Co-authored-by: Niv vaknin <122722245+nivcertora@users.noreply.github.com> Co-authored-by: liav-certora <114004726+liav-certora@users.noreply.github.com> Co-authored-by: liav-certora <liav@certora.com> Co-authored-by: urikirsh <38188877+urikirsh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://certora.atlassian.net/browse/CERT-8958