Config inheritance Example #168
Conversation
yoav-el-certora
left a comment
yoav-el-certora
left a comment
There was a problem hiding this comment.
You are missing 2 cases from the ticket
This case is test not an example: |
There was a problem hiding this comment.
Looks good from my point of view.
@urikirsh Do we want to present anything else here?
yoav-el-certora
left a comment
yoav-el-certora
left a comment
There was a problem hiding this comment.
@nivcertora @rahav-certora Is there a reason why base.conf structure is different than new_fields.conf?
i.e all keys in base.conf and invalid_base.conf are wrapped with "" (like jsons) and new_fields.conf, override_fields.conf not?
…/Examples into niv/CERT-8690-Config-inheritance
Fixed |
Co-authored-by: urikirsh <38188877+urikirsh@users.noreply.github.com>
…/Examples into niv/CERT-8690-Config-inheritance
urikirsh
left a comment
urikirsh
left a comment
There was a problem hiding this comment.
Thanks for fixing, looks good
|
@yoav-el-certora - according to the JSON specifications keys need to be in double quotes. Recently I see more and more people not using them, it is allowed in JavaScript but not in JSON, but it works |
This is exactly why I asked to change this here |
* Niv/cert 8248 revert example (#155) * CERT 8248 Add Revert Example * Update README * Address Christiane review * Update example based on Nurit Review * Clean * Update config.yml (#160) Co-authored-by: yoav-el-certora <122207807+yoav-el-certora@users.noreply.github.com> * Example ready * christiane cr * Code reviews * Config inheritance Example (#168) * Config inheritance Example * Update example based on review * CERT add invalid base conf * Update base.conf * CR comment * Update CVLByExample/ConfInheritance/invalid_base.conf Co-authored-by: urikirsh <38188877+urikirsh@users.noreply.github.com> * Fix invalid example --------- Co-authored-by: urikirsh <38188877+urikirsh@users.noreply.github.com> * Niv/cert 8958 add require reasoning (#172) * Add reasoning for require example * Address Nurit comments --------- Co-authored-by: Niv vaknin <122722245+nivcertora@users.noreply.github.com> Co-authored-by: liav-certora <114004726+liav-certora@users.noreply.github.com> Co-authored-by: liav-certora <liav@certora.com> Co-authored-by: urikirsh <38188877+urikirsh@users.noreply.github.com>
https://certora.atlassian.net/browse/CERT-8690