Add foundry.toml to example #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Foundry configuration by migrating from remappings.txt to a standardized foundry.toml configuration file. This change aligns the example with current Foundry best practices and provides a more comprehensive project setup.
- Replaces
remappings.txtwith a properfoundry.tomlconfiguration file - Updates README.md with comprehensive Foundry documentation and usage instructions
- Maintains the same dependency remappings while using the modern configuration format
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FoundryIntegration/SimpleDappTest/remappings.txt | Removes the legacy remappings file |
| FoundryIntegration/SimpleDappTest/foundry.toml | Adds modern Foundry configuration with remappings and project settings |
| FoundryIntegration/SimpleDappTest/README.md | Updates documentation with comprehensive Foundry usage guide |
| ### Deploy | ||
|
|
||
| ```shell | ||
| $ forge script script/Counter.s.sol:CounterScript --rpc-url <your_rpc_url> --private-key <your_private_key> |
There was a problem hiding this comment.
The deploy example references 'Counter.s.sol' which doesn't appear to exist in this SimpleDapp project. This should reference the actual deployment script for the SimpleDapp contract or be updated to reflect the correct script name.
Suggested change
| $ forge script script/Counter.s.sol:CounterScript --rpc-url <your_rpc_url> --private-key <your_private_key> | |
| $ forge script script/SimpleDapp.s.sol:SimpleDappScript --rpc-url <your_rpc_url> --private-key <your_private_key> |
urikirsh
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.