Conversation
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
…hm-template-java Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR prepares version 0.0.6 by standardizing naming conventions, updating dependencies, and improving the development workflow. The primary goal is to align the artifactId with the repository name and enhance the project's documentation and CI/CD pipeline.
Key Changes:
- Project naming alignment: Changed artifactId from
CS203_DSAA_template_javatoalgorithm-templateto match repository naming conventions - Dependency management: Consolidated lombok and slf4j dependencies to the root POM and updated versions for better compatibility
- Documentation enhancement: Added Java version strategy section and quick start guide with clearer instructions for OJ submission workflow
Reviewed Changes
Copilot reviewed 102 out of 108 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated artifactId, version, dependencies, and added project metadata |
| README.md | Extensive documentation improvements with Java version strategy and quick start guide |
| lab_welcome/*/pom.xml | Updated parent artifactId references across all lab modules |
| .github/workflows/* | Simplified CI workflow by removing manual zip operations and updating action versions |
| Multiple Java files | Added consistent SPDX copyright headers |
Files not reviewed (6)
- .idea/.gitignore: Language not supported
- .idea/codeStyles/.gitignore: Language not supported
- .idea/codeStyles/Project.xml: Language not supported
- .idea/codeStyles/codeStyleConfig.xml: Language not supported
- .idea/vcs.xml: Language not supported
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| 1. A+B: lab_00_A ,测试样例 | ||
| # 仅运行某一题(例如 lab_welcome_a)的测试 | ||
| mvn -q -pl lab_welcome/lab_welcome_a -am test |
There was a problem hiding this comment.
This command conflicts with the earlier statement about using -f for single module testing. Consider removing this line since the recommended approach is shown on line 64 using the -f option.
| mvn -q -pl lab_welcome/lab_welcome_a -am test |
| import java.util.List; | ||
|
|
||
| @Slf4j | ||
| @TestMethodOrder(MethodOrderer.OrderAnnotation.class) |
There was a problem hiding this comment.
| st = new StringTokenizer(""); | ||
| } | ||
|
|
||
| public boolean hasNext() { | ||
| while (!st.hasMoreTokens()) { |
There was a problem hiding this comment.
Initializing StringTokenizer with an empty string is unnecessary since it's immediately reassigned in the hasNext() method. Consider initializing as st = null; and adding a null check in hasNext().
| st = new StringTokenizer(""); | |
| } | |
| public boolean hasNext() { | |
| while (!st.hasMoreTokens()) { | |
| st = null; | |
| } | |
| public boolean hasNext() { | |
| while (st == null || !st.hasMoreTokens()) { |
Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Description
主要目标:
变更摘要:
@Slf4j的编译问题--release 11产物兼容 OJmvn -q -f lab_welcome/lab_welcome_a/pom.xml test(替代-pl ... -am)cal_warpper更正为cal;去除无用 HTML 换行;统一 OJ/Java 大小写Main.javazip步骤,改为直接用actions/upload-artifact@v4上传目录并排除.git,避免二次压缩请参考:该 PR 不引入破坏性变更,主要集中在文档与 CI/构建体验优化。
Fixes # (issue)
Type of change
How Has This Been Tested?
GitHub Actions:
mvn clean compile test验证构建与测试upload-artifact直接压缩,且不包含.git,无二次压缩本地验证(Windows PowerShell):
mvn -q test运行根项目测试mvn -q -f lab_welcome/lab_welcome_a/pom.xml test单模块测试命令可用文档校对:
Test A:GitHub Actions 矩阵构建与测试通过(CI)
Test B:单模块测试命令(-f 指定 pom)可执行并通过
Test Configuration:
Checklist: