EXT_feature_metadata JSON schema cleanup#6
EXT_feature_metadata JSON schema cleanup#6kring wants to merge 30 commits intoCesiumGS:3d-tiles-nextfrom
Conversation
…eTable.property.schema.json Co-authored-by: Peter Gagliardi <ptrgags@gmail.com>
Feature metadata extension (EXT_feature_metadata)
Also don't mark any properties of gltf.EXT_feature_metadata required, because I don't think they are.
|
By the way, are we sure we want specify min/max/etc to be |
| "not": { | ||
| "required": [ | ||
| "schema", | ||
| "schemaUri" | ||
| ] |
There was a problem hiding this comment.
This is to ensure that schema and schemaUri are mutually exclusive and was copied from camera.schema.json in the glTF spec:
I wonder if there's a better way to do this.
| "type": [ | ||
| "number", | ||
| "array" | ||
| ] | ||
| ], | ||
| "items": { | ||
| "type": "number" | ||
| } |
There was a problem hiding this comment.
The type should "integer" in both places here. I just pushed a fix related to that b3f48c2
I've debated this too. I'm not a huge fan of single element arrays since scalar properties tend to be way more common in metadata and the array form adds clutter/confusion IMO. I'd rather see the min/max value match the type exactly. Also there is better symmetry with the I think glTF gets away with it because scalar accessors are not all that common. I understand why it's done though. |
|
@kring thanks for the fixes and sorry for such a late review on this, I missed have must it when you posted it. Looks good I just had a couple comments. |
b3f48c2 to
3bf5af9
Compare
|
Merged these changes in #10 |
Fixes some small things I noticed while adding this extension to cesium-native:
not.requiredproperty.