-
Notifications
You must be signed in to change notification settings - Fork 105
Docs update namespace profiles for solana and eip155 to align with the new template
#155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bumblefudge
merged 2 commits into
ChainAgnostic:main
from
0xMonoAx:docs--update-caip350-solana-eip155
Nov 7, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,11 +65,11 @@ For text representation, the 20 bytes of EVM addresses should be hexadecimal-enc | |
| This standard deliberately does not define the text representation of EVM addresses if they are extended in the future, since it's not possible to know which human-readable representation will be more familiar to users in such hypothetical scenario. | ||
| This profile should be amended in the future to reflect it in such a case. | ||
|
|
||
| ##### Text representation -> customary text address formats conversion | ||
| ##### Text representation -> native representation conversion | ||
|
|
||
| See [EIP-55]. | ||
|
|
||
| ##### Customary text addresses -> text representation conversion | ||
| ##### Native representation -> text representation conversion | ||
|
|
||
| See [EIP-55]. | ||
|
|
||
|
|
@@ -90,13 +90,17 @@ Specified in [EIP-55]. | |
|
|
||
| See [EIP-55]. | ||
|
|
||
| ### Error handling | ||
|
|
||
| ### Implementation considerations | ||
|
|
||
| ### Extra considerations | ||
|
|
||
| Wallets and other software are expected to be able to fetch the extra information needed to convert from [CAIP-2] to this standard. | ||
|
|
||
| ## References | ||
|
|
||
| [^1]: This makes it possible to represent some chains using the full word as their chainid, which CAIP-2 does not support since the set of values representable with 32 `a-zA-Z0-9` characters has less than `type(uint256).max` elements. This is done in an effort to support chains whose ID is the output of `keccak256`, as proposed in [ERC-7785]. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this no longer the case? 👀
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The ERC-7785 idea was dropped, and the decision was made to move forward with ERC-7930. You can read more here. |
||
| [^1]: This makes it possible to represent some chains using the full word as their chainid, which CAIP-2 does not support since the set of values representable with 32 `a-zA-Z0-9` characters has less than `type(uint256).max` elements. | ||
| [^2]: With EVM Object Format as a prerequisite, Address Space Expansion could be implemented. If that happens, expanded addresses may be represented in 32 bytes, but pre-expansion addresses must remain 20 bytes in order to preserve a consistent address. | ||
|
|
||
| [CAIP-2]: https://chainagnostic.org/CAIPs/caip-2 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these placeholders for future error handling and implementation considerations? i'd rather have no sections than empty sections (I should probably add that to the CASA style guide and template files).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, since these are for future implementations, it makes sense to keep them only in the template for now to avoid having empty sections