This repository was archived by the owner on Jul 13, 2022. It is now read-only.
Merged
Conversation
Contributor
noot
commented
Dec 11, 2019
noot
commented
- add keypair to eth connection
- implement signing of tx in SubmitTx for ethereum
- to sign a tx, the function takes a Signer which is created from a geth ChainConfig. we need to add which eth chain config to use to the config, see todo in chains/ethereum/ethereum.go
GregTheGreek
previously requested changes
Dec 12, 2019
ansermino
approved these changes
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.