This repository was archived by the owner on Jul 13, 2022. It is now read-only.
Merged
Conversation
noot
reviewed
Dec 12, 2019
noot
reviewed
Dec 12, 2019
noot
reviewed
Dec 12, 2019
noot
reviewed
Dec 12, 2019
noot
reviewed
Dec 12, 2019
noot
reviewed
Dec 12, 2019
noot
reviewed
Dec 12, 2019
noot
reviewed
Dec 12, 2019
noot
reviewed
Dec 12, 2019
noot
reviewed
Dec 12, 2019
Member
Author
|
@noot Fixed. |
Contributor
|
Looks good, add tests pls |
Member
Author
|
@noot @ansermino I'm happy with the current state of this. Please re-review, everything has been changed. |
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
noot
reviewed
Dec 17, 2019
Contributor
noot
left a comment
noot
left a comment
There was a problem hiding this comment.
overall good, have some comments to be addressed. overall, let's add some events and more tests for edge cases
…dgeV2 into greg/contracts/intial
Merged
Member
Author
|
@ansermino @noot g2g |
noot
approved these changes
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr introduces the basic outline of the deposit contract on the Ethereum side. Somewhat opinionated, happy to discuss this and use it as a starting point
Glossary:
Includes:
Missing:
Issues:
Partially completes #8