Skip to content

ci: use release-please to manage and publish releases#33

Merged
wemeetagain merged 7 commits intomainfrom
nh/release-please
Apr 29, 2025
Merged

ci: use release-please to manage and publish releases#33
wemeetagain merged 7 commits intomainfrom
nh/release-please

Conversation

@nazarhussain
Copy link

Motivation

Use consistent tooling across all our codebase.

Description

  • Use release-please instead of manual publish
  • Use and maintain a change log file

Steps to test or reproduce

  • Run all tests

@github-actions
Copy link

github-actions bot commented Apr 10, 2025

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 2dc0944 Previous: null Ratio
sum array with raw for loop 933.51 us/op
sum array with reduce 10.202 ms/op
sum array with reduce beforeEach 81.446 us/op
sum array with reduce before beforeEach 81.652 us/op
sum array with reduce high threshold 10.221 ms/op
sum array with reduce no threshold 10.222 ms/op

by benchmarkbot/action

]
}
},
"changelog-sections": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this "changelog-sections" defined? can we just use the default?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values were not well documented, so I thought to set those explicitly.

Found it now in their code.
https://github.com/googleapis/release-please/blob/422df5a6a9d44a52c6c682563d1795b8fd246215/docs/manifest-releaser.md?plain=1#L185

Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wemeetagain wemeetagain merged commit 7ce43f3 into main Apr 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants