Skip to content

fix: wait for network idle in e2e#255

Merged
LesnyRumcajs merged 1 commit intomainfrom
fix-e2e-flakiness
Jun 5, 2025
Merged

fix: wait for network idle in e2e#255
LesnyRumcajs merged 1 commit intomainfrom
fix-e2e-flakiness

Conversation

@LesnyRumcajs
Copy link
Member

Summary of changes

Changes introduced in this pull request:

  • This might not be the best way to fix e2e flakiness, especially if we introduce more network events to the faucet, but it resolves the e2e flakiness that we experience at the moment. A better solution might come as a follow-up.

https://grafana.com/docs/k6/latest/javascript-api/k6-browser/page/waitfornavigation/#events

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes
    should be reflected in this document.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.03%. Comparing base (997dc9a) to head (912075f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   18.03%   18.03%           
=======================================
  Files          39       39           
  Lines        2085     2085           
=======================================
  Hits          376      376           
  Misses       1709     1709           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jun 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2025
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jun 5, 2025
Merged via the queue into main with commit 3088195 Jun 5, 2025
4 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-e2e-flakiness branch June 5, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants