-
Notifications
You must be signed in to change notification settings - Fork 186
Open
Labels
Type: TaskDiscrete task to implementDiscrete task to implement
Description
Summary
It appears that Forest diverges from Lotus in how the sequence number (Nonce) is calculated.
In Lotus, the MpoolPushMessage RPC method uses a message signer module to sign the message, retrieve the next nonce, and store a message UUID in the signer.
Our MpoolGetNonce RPC method implementation seems to deviate from Lotus as well.
This divergence could be a contributing factor to failure of the "send message" subcommand.
Completion Criteria
- Investigate the differences and gather evidence that the bug is caused by incorrect Nonce handling (if possible).
- Develop unit tests that cover all
MpoolPushMessageandMpoolGetNonceimplementations, identifying edge cases where our implementation falls short. - Refactor the Nonce calculation to align with Lotus message signer approach.
- Integrate the relatively new
sanityCheckOutgoingMessagelogic, which we currently lack.
Additional Links & Resources
https://github.com/filecoin-project/lotus/blob/v1.30.0-rc2/chain/messagesigner/messagesigner.go
https://github.com/filecoin-project/lotus/blob/v1.30.0-rc2/node/impl/full/mpool.go#L307
#2726
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type: TaskDiscrete task to implementDiscrete task to implement
Type
Projects
Status
In review