Skip to content

Uncomment GoldenWeek from ForkUpgradeParams #6707

@LesnyRumcajs

Description

@LesnyRumcajs

Summary

The field upgrade_golden_week_height in ForkUpgradeParams
(and their corresponding entries in the TryFrom<&ChainConfig> implementation) is
currently commented out in src/rpc/methods/state.rs as part of the nv28 skeleton PR (#6706).

These need to be uncommented once the upgrade heights are finalised. Note that this will
also require generating new RPC snapshots.

Tasks

  • Uncomment upgrade_golden_week_height: ChainEpoch and upgrade_xxx_height: ChainEpoch
    in the ForkUpgradeParams struct
  • Uncomment upgrade_golden_week_height: get_height(GoldenWeek)? in the TryFrom<&ChainConfig> implementation
  • Update the OpenRPC specs (docs/openrpc-specs/v0.json and docs/openrpc-specs/v1.json)
    accordingly
  • Generate new RPC snapshots (required due to the ForkUpgradeParams struct change)

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: TaskDiscrete task to implement

    Type

    No type

    Projects

    Status

    New

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions