-
Notifications
You must be signed in to change notification settings - Fork 184
Open
Labels
Type: TaskDiscrete task to implementDiscrete task to implement
Description
Summary
The field upgrade_golden_week_height in ForkUpgradeParams
(and their corresponding entries in the TryFrom<&ChainConfig> implementation) is
currently commented out in src/rpc/methods/state.rs as part of the nv28 skeleton PR (#6706).
These need to be uncommented once the upgrade heights are finalised. Note that this will
also require generating new RPC snapshots.
Tasks
- Uncomment
upgrade_golden_week_height: ChainEpochandupgrade_xxx_height: ChainEpoch
in theForkUpgradeParamsstruct - Uncomment
upgrade_golden_week_height: get_height(GoldenWeek)?in theTryFrom<&ChainConfig>implementation - Update the OpenRPC specs (
docs/openrpc-specs/v0.jsonanddocs/openrpc-specs/v1.json)
accordingly - Generate new RPC snapshots (required due to the
ForkUpgradeParamsstruct change)
References
- PR
#6706— nv28 skeleton
(comment: chore: nv28 skeleton #6706 (comment))
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type: TaskDiscrete task to implementDiscrete task to implement
Type
Projects
Status
New