Closed
Conversation
Contributor
Author
|
Just going to close this for now, if we need to add our own functionality on this type can just use these changes as a template to reimplement. |
This was referenced Jan 14, 2020
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will leave as draft until agreed upon. Another option is to just alias the Bigint types through this crate without wrapping it just to keep consistent version and allowing it to be more easily changed if custom functionality is needed in future.
All of this is optional but seeing interactions needed in the near future, for example Cbor encoding, let me know if you guys want this.
I only changed usage in the vm package as well for this, since no one else is modifying, and can change the other references once agreed upon and probably in a seperate PR