-
Notifications
You must be signed in to change notification settings - Fork 181
fix: ignore a few RUSTSECs #6180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds six RUSTSEC advisory identifiers to the ignore list in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
deny.toml (1)
10-15: Consider consolidating the repetitive comment.All six entries share identical rationale. You could consolidate them with a single comment to reduce duplication, though individual comments do provide clarity on which advisory maps to which entry.
Suggested consolidation approach (optional):
- "RUSTSEC-2025-0098", # All Unicode crates that are part of https://github.com/open-i18n/rust-unic are unmaintained. - "RUSTSEC-2025-0104", # All Unicode crates that are part of https://github.com/open-i18n/rust-unic are unmaintained. - "RUSTSEC-2025-0074", # All Unicode crates that are part of https://github.com/open-i18n/rust-unic are unmaintained. - "RUSTSEC-2025-0075", # All Unicode crates that are part of https://github.com/open-i18n/rust-unic are unmaintained. - "RUSTSEC-2025-0080", # All Unicode crates that are part of https://github.com/open-i18n/rust-unic are unmaintained. - "RUSTSEC-2025-0081", # All Unicode crates that are part of https://github.com/open-i18n/rust-unic are unmaintained. + # All Unicode crates that are part of https://github.com/open-i18n/rust-unic are unmaintained. + "RUSTSEC-2025-0098", + "RUSTSEC-2025-0104", + "RUSTSEC-2025-0074", + "RUSTSEC-2025-0075", + "RUSTSEC-2025-0080", + "RUSTSEC-2025-0081",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
deny.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: tests
- GitHub Check: tests-release
- GitHub Check: cargo-publish-dry-run
- GitHub Check: Build Ubuntu
- GitHub Check: Build MacOS
- GitHub Check: All lint checks
🔇 Additional comments (1)
deny.toml (1)
10-15: RUSTSEC identifiers verified as legitimate and correctly mapped to rust-unic crates.All six advisories (RUSTSEC-2025-0098, RUSTSEC-2025-0104, RUSTSEC-2025-0074, RUSTSEC-2025-0075, RUSTSEC-2025-0080, RUSTSEC-2025-0081) correctly correspond to unmaintained Unicode crates that are part of the rust-unic project. The suppressions are appropriate for informational advisories about unmaintained crates, which cannot be remediated through upstream updates. The identical justification comment is accurate and the changes align with the documented motivation.
|
Hopefully, we can remove the ignores (at least some of them) once Keats/tera#978 is resolved and a new version is released. I believe it's the only package we depend on directly that uses those unmaintained crates. |
Summary of changes
To fix
cargo deny check advisoriesfailures.Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #6179
Other information and links
Change checklist
Summary by CodeRabbit