Skip to content

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jan 23, 2026

Summary of changes

Changes introduced in this pull request:

  • it's the only occurrence I could find that's actually simplifying things.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

Release Notes

  • New Features
    • Added a new synchronization state for scenarios where snapshot synchronization is not required
    • Enhanced snapshot synchronization status messages with improved clarity and visual indicators for initialization, in-progress, completion, and not-required states

✏️ Tip: You can customize this high-level summary in your review settings.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 23, 2026 12:38
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team January 23, 2026 12:38
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

Walkthrough

The SnapshotProgressState enum is refactored to use derive_more::Display instead of manual std::fmt::Display implementation. A new NotRequired variant is introduced, and all variants are annotated with explicit display formatting strings for consistent emoji-prefixed output.

Changes

Cohort / File(s) Summary
SnapshotProgressState enum refactoring
src/rpc/methods/sync/types.rs
Replace manual Display impl with derive_more::Display; add NotRequired variant with display annotation "⏳ Not Required (Snapshot is not needed)"; annotate existing variants (Initializing, InProgress, Completed) with emoji-prefixed display strings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • hanabi1224
  • akaladarshi
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: simplifying snapshot status display implementation using derive_more crate, which aligns perfectly with the code modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 23, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2026
@hanabi1224 hanabi1224 added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit 90ebac8 Jan 23, 2026
34 checks passed
@hanabi1224 hanabi1224 deleted the simplify-snapshot-status-display-impl branch January 23, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants