Skip to content

Enable support for Filecoin.EthNewFilter V2#6513

Open
sudo-shashank wants to merge 6 commits intomainfrom
shashank/enable-eth-new-filter-v2
Open

Enable support for Filecoin.EthNewFilter V2#6513
sudo-shashank wants to merge 6 commits intomainfrom
shashank/enable-eth-new-filter-v2

Conversation

@sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Feb 3, 2026

Summary of changes

Changes introduced in this pull request:

  • Enabled support for Filecoin.EthNewFilter V2 as Safe and Finalized are not yet implemented in lotus.

Reference issue to close (if applicable)

Closes #6304

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • New Features

    • EthNewFilter RPC method is now available for API v2.
  • Chores

    • Updated link checker exclusions for bot-protected domains.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

Walkthrough

This PR enables the Filecoin.EthNewFilter RPC method for API v2 routing by updating the API_PATHS configuration. Changes include modifying the RPC method's API path coverage, updating the changelog, and excluding a domain in link checking configuration due to bot protection restrictions.

Changes

Cohort / File(s) Summary
API v2 Routing
src/rpc/methods/eth.rs
Updated EthNewFilter RPC method's API_PATHS from ApiPaths::all() to ApiPaths::all_with_v2() to enable v2 API path support.
Configuration & Documentation
.config/lychee.toml, CHANGELOG.md
Added exclusion filter for probelab.io domain (bot protection/403) and recorded changelog entry for EthNewFilter v2 API enablement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • akaladarshi
  • LesnyRumcajs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive Linked issue #6304 lacks completion criteria and specific requirements, making it impossible to validate whether code changes meet defined objectives. The linked issue #6304 provides no completion criteria or specific technical requirements to assess against the code changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Enable support for Filecoin.EthNewFilter V2' directly and clearly describes the main change in the pull request.
Out of Scope Changes check ✅ Passed All changes are directly related to enabling Filecoin.EthNewFilter V2: API path routing, changelog entry, and exclusion rule for a problematic domain.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shashank/enable-eth-new-filter-v2

Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashank sudo-shashank added RPC requires calibnet RPC checks to run on CI labels Feb 4, 2026
@sudo-shashank sudo-shashank marked this pull request as ready for review February 4, 2026 11:36
@sudo-shashank sudo-shashank requested a review from a team as a code owner February 4, 2026 11:36
@sudo-shashank sudo-shashank requested review from LesnyRumcajs and akaladarshi and removed request for a team February 4, 2026 11:36
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.31%. Comparing base (5157235) to head (2df5e16).

Additional details and impacted files
Files with missing lines Coverage Δ
src/rpc/methods/eth.rs 69.55% <ø> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5157235...2df5e16. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sudo-shashank sudo-shashank added this pull request to the merge queue Feb 4, 2026
@sudo-shashank sudo-shashank removed this pull request from the merge queue due to a manual request Feb 4, 2026
@sudo-shashank sudo-shashank added this pull request to the merge queue Feb 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RPC v2] Filecoin.EthNewFilter

2 participants