Skip to content

fix(test): retry cargo test on CI#6566

Merged
hanabi1224 merged 2 commits intomainfrom
hm/retry-cargo-test-ci
Feb 9, 2026
Merged

fix(test): retry cargo test on CI#6566
hanabi1224 merged 2 commits intomainfrom
hm/retry-cargo-test-ci

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Feb 9, 2026

Summary of changes

Add retry to mitigate #6565

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Tests
    • Enhanced test infrastructure to improve reliability of regression and state management tests.

@hanabi1224 hanabi1224 marked this pull request as ready for review February 9, 2026 10:08
@hanabi1224 hanabi1224 requested a review from a team as a code owner February 9, 2026 10:08
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and removed request for a team February 9, 2026 10:08
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

Walkthrough

This pull request adds the #[fickle::fickle] attribute to test functions across the codebase, enabling flaky test handling. Changes include decorating generated RPC regression tests in the build script and state manager utility tests, with no modifications to test logic or functionality.

Changes

Cohort / File(s) Summary
Build Script RPC Tests
build.rs
Added #[fickle::fickle] attribute to generated RPC regression test functions via rpc_regression_tests_gen for flaky test handling.
State Manager Tests
src/state_manager/utils.rs
Added #[fickle::fickle] attribute to 14 test functions covering state compute and state validate operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
  • sudo-shashank
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to add a retry mechanism for cargo test on CI, but the actual changes only add #[fickle::fickle] attributes to test functions in build.rs and state_manager/utils.rs without implementing retry logic. Update the title to accurately reflect the changes, such as 'feat(test): add fickle attribute to flaky tests' or provide the actual retry mechanism implementation that the title describes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/retry-cargo-test-ci

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.35%. Comparing base (86cb824) to head (2420d7d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/state_manager/utils.rs 81.77% <ø> (-0.54%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86cb824...2420d7d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit 4c8f481 Feb 9, 2026
58 of 59 checks passed
@hanabi1224 hanabi1224 deleted the hm/retry-cargo-test-ci branch February 9, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants