Skip to content

chore: fix wording in snapshot download#6669

Merged
LesnyRumcajs merged 1 commit intomainfrom
snaps-not-downloaded-to-cwd
Mar 2, 2026
Merged

chore: fix wording in snapshot download#6669
LesnyRumcajs merged 1 commit intomainfrom
snaps-not-downloaded-to-cwd

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Mar 2, 2026

Summary of changes

snapshots are not downloaded to the CWD - they are downloaded to to forest data dir (normally). Let's just omit this info.

Changes introduced in this pull request:

  • fixed snapshot download wording

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Refactor
    • Simplified snapshot fetch prompt messages by removing redundant directory path information, improving clarity and user experience while maintaining all existing functionality.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner March 2, 2026 09:50
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and sudo-shashank and removed request for a team March 2, 2026 09:50
@LesnyRumcajs LesnyRumcajs enabled auto-merge March 2, 2026 09:50
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 097ee9c and 7c802c9.

📒 Files selected for processing (2)
  • src/daemon/mod.rs
  • src/tool/offline_server/server.rs

Walkthrough

User-facing prompt messages are updated in two files by removing "to the current directory" from snapshot download confirmation dialogs. The changes affect only the text strings displayed to users; all underlying logic and control flow remain unchanged.

Changes

Cohort / File(s) Summary
Snapshot Download Prompts
src/daemon/mod.rs, src/tool/offline_server/server.rs
Removed "to the current directory" phrase from user-facing snapshot fetch confirmation messages. Both files update the same prompt pattern to simplify the user-visible text.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • hanabi1224
  • sudo-shashank
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: fixing wording in snapshot download prompts across two files. It directly reflects the correction of misleading user-facing text about snapshot download location.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch snaps-not-downloaded-to-cwd

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.48%. Comparing base (097ee9c) to head (7c802c9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/daemon/mod.rs 28.98% <ø> (ø)
src/tool/offline_server/server.rs 30.66% <ø> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097ee9c...7c802c9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Mar 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 2, 2026
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 09e044f Mar 2, 2026
34 checks passed
@LesnyRumcajs LesnyRumcajs deleted the snaps-not-downloaded-to-cwd branch March 2, 2026 11:26
@coderabbitai coderabbitai bot mentioned this pull request Mar 13, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants