Conversation
WalkthroughThe PR updates API conformance reporting by standardizing status legends across documentation and the script that generates reports. It clarifies status semantics (✅ = Tested, ➖ = Not tested, N/A = Forest-specific) and reclassifies numerous Filecoin and F3 methods from ❌ to ➖ status, reflecting refined testing categorization without implementation changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/tests/api_compare/convert_report_to_markdown.sh (1)
36-41: Minor inconsistency between legend and generated output.The legend on line 27 describes
N/Aas "Forest-specific method (not in Lotus)", but the actual generated output on line 38 renders asN/A (Forest-specific). Consider updating the legend to match the exact output format for consistency:📝 Suggested fix
- echo "- N/A: Forest-specific method (not in Lotus)" + echo "- N/A (Forest-specific): Method only exists in Forest (not in Lotus)"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/tests/api_compare/convert_report_to_markdown.sh` around lines 36 - 41, The legend text and the jq output are inconsistent: the jq filter in the convert_report_to_markdown.sh script emits "N/A (Forest-specific)" for Forest-only methods (see the branch that checks startswith("Forest.") in the jq expression), so update the legend line that currently says 'N/A: Forest-specific method (not in Lotus)' to exactly match the generated output "N/A (Forest-specific)" so the legend and the output are identical.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@scripts/tests/api_compare/convert_report_to_markdown.sh`:
- Around line 36-41: The legend text and the jq output are inconsistent: the jq
filter in the convert_report_to_markdown.sh script emits "N/A (Forest-specific)"
for Forest-only methods (see the branch that checks startswith("Forest.") in the
jq expression), so update the legend line that currently says 'N/A:
Forest-specific method (not in Lotus)' to exactly match the generated output
"N/A (Forest-specific)" so the legend and the output are identical.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 18b2d54c-e277-407b-a5e6-49241ae985c2
📒 Files selected for processing (3)
docs/docs/users/reports/api_conformance/report_2026-01-20.mddocs/docs/users/reports/api_conformance/report_2026-02-01.mdscripts/tests/api_compare/convert_report_to_markdown.sh
Summary of changes
This came up yesterday during a discussion with FilOz. This should make it more appealing and clear.
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
Documentation