Conversation
WalkthroughFour new environment variables (FOREST_PLEDGE_RULE_RAMP, FOREST_DRAND_INCENTINET_CONFIG, FOREST_GENESIS_NETWORK_VERSION, FOREST_TIPSET_CACHE_DISABLED) were added to the environment variables reference with type, default, example, and description entries. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/docs/users/reference/env_variables.md (1)
64-64: Consider calling out the Lotus name here.Operators migrating from Lotus may look for
LOTUS_GENESIS_NETWORK_VERSION, so a brief note that this is Forest’s equivalent would make the docs a bit more discoverable.✏️ Suggested wording
-| `FOREST_GENESIS_NETWORK_VERSION` | non-negative integer | empty | 25 | Override the genesis network version (devnet only) | +| `FOREST_GENESIS_NETWORK_VERSION` | non-negative integer | empty | 25 | Override the genesis network version (devnet only). Forest-specific equivalent of Lotus's `LOTUS_GENESIS_NETWORK_VERSION` |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/docs/users/reference/env_variables.md` at line 64, Update the env var description for FOREST_GENESIS_NETWORK_VERSION to explicitly mention Lotus by adding a short note like "This is Forest's equivalent of LOTUS_GENESIS_NETWORK_VERSION" so operators migrating from Lotus can find it; locate the table row referencing FOREST_GENESIS_NETWORK_VERSION in docs/users/reference/env_variables.md and append the suggested clarifying text to the description cell for that symbol.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/docs/users/reference/env_variables.md`:
- Line 64: Update the env var description for FOREST_GENESIS_NETWORK_VERSION to
explicitly mention Lotus by adding a short note like "This is Forest's
equivalent of LOTUS_GENESIS_NETWORK_VERSION" so operators migrating from Lotus
can find it; locate the table row referencing FOREST_GENESIS_NETWORK_VERSION in
docs/users/reference/env_variables.md and append the suggested clarifying text
to the description cell for that symbol.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: e08268a1-4a56-43fa-ae00-6b3cb67c451c
📒 Files selected for processing (1)
docs/docs/users/reference/env_variables.md
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit