Skip to content

Fix EthSyncing RPC error#6840

Merged
sudo-shashank merged 1 commit intomainfrom
shashank/fix-ethsyncing-rpc
Apr 1, 2026
Merged

Fix EthSyncing RPC error#6840
sudo-shashank merged 1 commit intomainfrom
shashank/fix-ethsyncing-rpc

Conversation

@sudo-shashank
Copy link
Copy Markdown
Contributor

@sudo-shashank sudo-shashank commented Apr 1, 2026

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • API Updates
    • Ethereum syncing status response fields updated to camelCase format: currentBlock, highestBlock, and startingBlock (previously lowercase variants). Applications using the eth_syncing RPC method must update field name references accordingly.

@sudo-shashank sudo-shashank added the RPC requires calibnet RPC checks to run on CI label Apr 1, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd57c6aa-a73c-4b2e-b9dc-6a3d4f18e228

📥 Commits

Reviewing files that changed from the base of the PR and between 1494a35 and c31eb5d.

⛔ Files ignored due to path filters (3)
  • src/rpc/snapshots/forest__rpc__tests__rpc__v0.snap is excluded by !**/*.snap
  • src/rpc/snapshots/forest__rpc__tests__rpc__v1.snap is excluded by !**/*.snap
  • src/rpc/snapshots/forest__rpc__tests__rpc__v2.snap is excluded by !**/*.snap
📒 Files selected for processing (4)
  • docs/openrpc-specs/v0.json
  • docs/openrpc-specs/v1.json
  • docs/openrpc-specs/v2.json
  • src/rpc/methods/eth.rs

Walkthrough

Updated JSON property names from lowercase to camelCase in the EthSyncingResultLotusJson schema across three OpenRPC specification versions and corresponding Rust serde mappings to maintain consistency with Ethereum API naming conventions.

Changes

Cohort / File(s) Summary
OpenRPC Specification Versions
docs/openrpc-specs/v0.json, docs/openrpc-specs/v1.json, docs/openrpc-specs/v2.json
Renamed EthSyncingResultLotusJson schema properties from lowercase to camelCase: currentblockcurrentBlock, highestblockhighestBlock, startingblockstartingBlock. Updated required field arrays accordingly.
Rust Serde Implementation
src/rpc/methods/eth.rs
Updated serde rename attributes on EthSyncingResultLotusJson::Syncing variant fields to match new camelCase JSON property names: startingblockstartingBlock, currentblockcurrentBlock, highestblockhighestBlock.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • akaladarshi
  • LesnyRumcajs
  • hanabi1224
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix EthSyncing RPC error' accurately reflects the main change—converting JSON field names to camelCase in the EthSyncingResultLotusJson schema across all OpenRPC spec versions and Rust code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shashank/fix-ethsyncing-rpc
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch shashank/fix-ethsyncing-rpc

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms


Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashank sudo-shashank marked this pull request as ready for review April 1, 2026 14:44
@sudo-shashank sudo-shashank requested a review from a team as a code owner April 1, 2026 14:44
@sudo-shashank sudo-shashank requested review from LesnyRumcajs and akaladarshi and removed request for a team April 1, 2026 14:44
@sudo-shashank sudo-shashank enabled auto-merge April 1, 2026 14:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@163a441). Learn more about missing BASE report.
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/rpc/methods/eth.rs 65.55% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 163a441...c31eb5d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sudo-shashank sudo-shashank added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 0fe81e6 Apr 1, 2026
50 of 75 checks passed
@sudo-shashank sudo-shashank deleted the shashank/fix-ethsyncing-rpc branch April 1, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants